feat(layout): intrinsic-safe flex stretch and min-width-stretch scroll (WIND-4) by anilcancakir · Pull Request #149 · fluttersdk/wind

anilcancakir · 2026-07-07T14:13:47Z

What (WIND-4)

Three coupled layout capabilities plus an actionable assert:

Intrinsic-safe internal layout: the w_div basis-* and column-stretch LayoutBuilders (which threw LayoutBuilder does not support returning intrinsic dimensions under an intrinsic-measuring ancestor, cascading to _owner != null on web) are replaced with real render objects: WindCrossStretch (a RenderProxyBox stretch) and WindMainExtentProvider/WindFractionBasis (fractional basis resolved against the flex's own extent through a layout-time port). A flex flex-col now renders inside an items-stretch grid cell / under IntrinsicHeight / in a Table cell without asserting.
Min-width-stretch scroll: a "fill on desktop, scroll on narrow" primitive composed from existing tokens (no new className): overflow-x-auto wrapper + w-full min-w-[Npx] inner. w-full inside a horizontal scroll now sizes to max(viewport, min-w-*) instead of asserting on the scroll's unbounded width.
Explicit flex flex-col items-stretch: equalizes child widths, closing the asymmetry with grid ... items-stretch.
h-full-in-vertical-scroll assert: a child resolving h-full under an overflow-y-auto/-scroll parent now fails fast with a message pointing at flex-1, threaded via WindMinWidthScrollScope (dev-only, stripped in release).

Why

Closes the LayoutBuilder-under-items-stretch crash (the uptizm CheckHistoryTable regression) and adds the missing responsive-table scroll primitive. Uses the intrinsic-free two-pass foundation already proven by WindEqualHeightRow; no LayoutBuilder is reintroduced on any intrinsic-reachable path.

Changes

lib/src/widgets/w_div.dart, wind_equal_height_row.dart; new lib/src/widgets/wind_min_width_scroll.dart, lib/src/state/wind_min_width_scroll_scope.dart.
test/flex/intrinsic_safe_layout_test.dart (new): reproduces the crash under IntrinsicHeight/grid items-stretch, asserts fill/scroll widths (720 fills, 300 -> 600 scrolls), items-stretch equalization, and the h-full assert (incl. the "same-element h-full is allowed" case).
5-surface doc sync: SKILL.md (2.8.2 -> 2.9.0), references/layouts.md, references/tailwind-divergence.md (reconciles the now-false "LayoutBuilder internally" claim), doc/layout/flexbox.md, doc/layout/overflow.md, example/lib/pages/layout/responsive_table.dart (new), CHANGELOG.md.

Verification

dart analyze clean, dart format clean, flutter test green (flex + pixel suites, including the items-stretch-ancestor and min-width-scroll cases).

Follow-up (out of scope, flagged)

A pre-existing h-full LayoutBuilder in the sizing section (w_div.dart) remains for the genuine unbounded-height NON-scroll case (a bare h-full under IntrinsicHeight with no scroll). Not introduced here (two flex-path LayoutBuilders were removed, none added); candidate for a future intrinsic-safe pass.

Note

Shares CHANGELOG.md / SKILL.md / tailwind-divergence.md with the WIND-1/5/3 PRs; whichever merges first, the others need a trivial rebase on those doc surfaces.

…l (WIND-4)

…ll (WIND-4)

…IND-4)

coderabbitai · 2026-07-07T14:13:58Z

Warning

Review limit reached

@anilcancakir, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bd1f48d-2b8f-4a9e-ae4a-69b17db71361

📥 Commits

Reviewing files that changed from the base of the PR and between 11db93d and d182416.

📒 Files selected for processing (14)

CHANGELOG.md
doc/layout/flexbox.md
doc/layout/overflow.md
example/lib/pages/layout/responsive_table.dart
example/lib/routes.dart
lib/src/state/wind_min_width_scroll_scope.dart
lib/src/widgets/w_div.dart
lib/src/widgets/wind_equal_height_row.dart
lib/src/widgets/wind_min_width_scroll.dart
skills/wind-ui/references/layouts.md
skills/wind-ui/references/tailwind-divergence.md
test/flex/intrinsic_safe_layout_test.dart
test/flex/wind_min_width_scroll_test.dart
test/flex/wind_render_objects_test.dart

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/intrinsic-safe-flex-min-width-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-07T14:17:48Z

Codecov Report

❌ Patch coverage is 97.38220% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/src/widgets/wind_equal_height_row.dart	95.12%	4 Missing ⚠️
lib/src/widgets/wind_min_width_scroll.dart	98.33%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR updates Wind’s layout internals to remove intrinsic-unsafe LayoutBuilder paths in WDiv flex layout, adds a horizontal “min-width-stretch” scroll primitive for responsive tables, and introduces a dev-time assert to catch h-full misuse inside vertical scrolls.

Changes:

Replace intrinsic-unsafe flex behaviors with render-object based primitives (WindCrossStretch, WindMainExtentProvider/WindFractionBasis) and update WDiv to use them.
Add “fill on desktop, scroll on narrow” behavior for overflow-x-auto + w-full min-w-[Npx] via a viewport-width port threaded through an inherited scope.
Add/extend tests, docs, examples, skill references, and changelog entries to reflect the new behavior and guarantees.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/flex/intrinsic_safe_layout_test.dart	New widget tests covering intrinsic-safe flex, fractional basis behavior, responsive horizontal scroll sizing, and the new `h-full`-in-scroll assert.
skills/wind-ui/SKILL.md	Bumps skill version metadata to 2.9.0.
skills/wind-ui/references/tailwind-divergence.md	Updates divergence notes for intrinsic-safe flex, responsive table scroll pattern, and the new `h-full` assert behavior.
skills/wind-ui/references/layouts.md	Updates guidance around `IntrinsicHeight` and clarifies which Wind flex paths are now intrinsic-safe vs. still constrained.
lib/src/widgets/wind_min_width_scroll.dart	New render-object widgets/ports to publish viewport width and size `w-full` content inside horizontal scrolls.
lib/src/widgets/wind_equal_height_row.dart	Adds render-object primitives for intrinsic-safe column stretch and fractional `basis-*` sizing against flex extent.
lib/src/widgets/w_div.dart	Integrates new render-object primitives, threads scroll scope signals, and adds the `h-full` inside vertical scroll assert + horizontal scroll `w-full` sizing.
lib/src/state/wind_min_width_scroll_scope.dart	New `InheritedWidget` for threading scroll axis/viewport width info to descendants.
example/lib/routes.dart	Registers the new responsive table example route.
example/lib/pages/layout/responsive_table.dart	New example page demonstrating responsive table scroll and explicit `items-stretch` columns.
doc/layout/overflow.md	Documents the responsive-table scroll composition and the new `h-full`-in-vertical-scroll assert behavior.
doc/layout/flexbox.md	Updates flexbox docs to reflect intrinsic-safe flex internals and explicit `items-stretch` semantics.
CHANGELOG.md	Adds WIND-4 entries describing intrinsic-safe flex, min-width-stretch horizontal scroll, `items-stretch` behavior, and the `h-full` assert.

… viewport When the scroll viewport width is unpublished (null) or infinite (the scroll sits in an unbounded-width context), the box no longer forces a tight (possibly 0) width that collapses a w-full child. It now lays the child out with the min-w-* floor as a lower bound and content width as the upper, mirroring WindCrossStretch / WindFractionBasis. Adds direct RenderObject tests for the finite / floor / null / infinite viewport cases.

…suite

anilcancakir · 2026-07-07T14:35:48Z

@coderabbitai review

coderabbitai · 2026-07-07T14:35:54Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

The unbounded/unpublished-viewport degradation laid the child out with maxWidth double.infinity and reported size = child.size, which could exceed a finite parent constraint (box used outside a scroll, or before a finite viewport publishes) and trip 'size not within constraints'. Both branches now clamp the floor/target into the incoming width range and re-constrain the reported size. Adds a finite-parent regression test.

…plicate test-group label The w_div basis comment still described the removed LayoutBuilder path; it now points at WindMainExtentProvider. The second flex test group no longer reuses the '(a)' label.

anilcancakir · 2026-07-07T14:52:13Z

@coderabbitai review

coderabbitai · 2026-07-07T14:52:21Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…-flex-min-width-scroll # Conflicts: # CHANGELOG.md

Directly exercises WindCrossStretch (bounded + unbounded), the column WindMainExtentProvider / WindFractionBasis basis path, a basis-factor and a flex-direction rebuild (render-object update path), the WindMinWidthBox floor setter, and WindMinWidthScrollScope.updateShouldNotify. Lifts patch coverage of the new render objects; the few remaining lines are unreachable null-child guards.

anilcancakir added 3 commits July 7, 2026 17:11

feat(layout): intrinsic-safe flex stretch and min-width-stretch scrol…

452de39

…l (WIND-4)

docs(example): add a responsive-table demo for min-width-stretch scro…

b90700c

…ll (WIND-4)

docs(layout): document intrinsic-safe stretch and min-width scroll (W…

b508251

…IND-4)

Copilot AI review requested due to automatic review settings July 7, 2026 14:13

Copilot started reviewing on behalf of anilcancakir July 7, 2026 14:14 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread lib/src/widgets/wind_min_width_scroll.dart Outdated

Comment thread test/flex/intrinsic_safe_layout_test.dart Outdated

anilcancakir added 2 commits July 7, 2026 17:35

test(flex): drop the unused textWidth helper from the intrinsic-safe …

a107476

…suite

anilcancakir requested a review from Copilot July 7, 2026 14:38

Copilot started reviewing on behalf of anilcancakir July 7, 2026 14:38 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread lib/src/widgets/wind_min_width_scroll.dart

Comment thread lib/src/widgets/w_div.dart Outdated

Comment thread test/flex/intrinsic_safe_layout_test.dart Outdated

anilcancakir added 2 commits July 7, 2026 17:51

chore(layout): correct the stale basis LayoutBuilder comment and a du…

7def632

…plicate test-group label The w_div basis comment still described the removed LayoutBuilder path; it now points at WindMainExtentProvider. The second flex test group no longer reuses the '(a)' label.

anilcancakir added 2 commits July 7, 2026 18:28

Merge remote-tracking branch 'origin/master' into feat/intrinsic-safe…

0dc6507

…-flex-min-width-scroll # Conflicts: # CHANGELOG.md

anilcancakir merged commit 4311759 into master Jul 7, 2026
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(layout): intrinsic-safe flex stretch and min-width-stretch scroll (WIND-4)#149

feat(layout): intrinsic-safe flex stretch and min-width-stretch scroll (WIND-4)#149
anilcancakir merged 9 commits into
masterfrom
feat/intrinsic-safe-flex-min-width-scroll

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Review limit reached

Uh oh!

codecov Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

anilcancakir commented Jul 7, 2026

What (WIND-4)

Why

Changes

Verification

Follow-up (out of scope, flagged)

Note

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

codecov Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anilcancakir commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

codecov Bot commented Jul 7, 2026 •

edited

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading