Skip to content

feat: add custom port support for sandbox - #7360

Open
muskan-creates352 wants to merge 5 commits into
flyteorg:masterfrom
muskan-creates352:final-real-clean-ports
Open

muskan-creates352 wants to merge 5 commits into
flyteorg:masterfrom
muskan-creates352:final-real-clean-ports

Conversation

@muskan-creates352

Copy link
Copy Markdown

Tracking issue

Closes #7346

Why are the changes needed?

The sandbox currently uses fixed port mappings by default. This becomes an issue when those ports are already occupied on the local machine, making it difficult to start the sandbox in some development environments.

What changes were proposed in this pull request?

This PR adds support for custom sandbox port mappings through a new --ports flag.

Changes made:

  • Added a Ports field to the sandbox configuration.
  • Updated sandbox startup logic to use custom ports when provided.
  • Updated Docker port parsing to accept user-defined mappings.
  • Preserved the existing default behavior when custom ports are not specified.

Example usage:

flytectl sandbox start --ports 8080:30081

How was this patch tested?

  • Ran go build ./...
  • Verified that the sandbox commands compile successfully.
  • Checked that flytectl sandbox start --help shows the new --ports flag correctly.

Checklist

  • All commits are signed-off.
  • Verified changes locally.

Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
@github-actions github-actions Bot added the flyte label May 10, 2026
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
@Sovietaced Sovietaced added flyte and removed flyte labels Jul 7, 2026
@Sovietaced

Copy link
Copy Markdown
Member

@muskan-creates352 this seems to be targeting the wrong branch

@muskan-creates352
muskan-creates352 changed the base branch from master to main October 6, 2026 05:57
@muskan-creates352
muskan-creates352 changed the base branch from main to master October 6, 2026 06:28
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.33%. Comparing base (363bea3) to head (5b8fddb).

Files with missing lines Patch % Lines
...tl/cmd/config/subcommand/sandbox/sandbox_config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7360   +/-   ##
=======================================
  Coverage   57.33%   57.33%           
=======================================
  Files         931      931           
  Lines       58329    58332    +3     
=======================================
+ Hits        33441    33444    +3     
  Misses      21835    21835           
  Partials     3053     3053           
Flag Coverage Δ
unittests-datacatalog 53.62% <ø> (ø)
unittests-flyteadmin 53.24% <ø> (ø)
unittests-flytecopilot 48.05% <ø> (ø)
unittests-flytectl 64.13% <71.42%> (+0.01%) ⬆️
unittests-flyteidl 76.63% <ø> (ø)
unittests-flyteplugins 60.64% <ø> (ø)
unittests-flytepropeller 53.84% <ø> (ø)
unittests-flytestdlib 64.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants