Repository navigation
feat: add custom port support for sandbox - #7360
Open
muskan-creates352 wants to merge 5 commits into
Open
muskan-creates352 wants to merge 5 commits into
muskan-creates352 wants to merge 5 commits into
Conversation
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
Member
|
@muskan-creates352 this seems to be targeting the wrong branch |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7360 +/- ##
=======================================
Coverage 57.33% 57.33%
=======================================
Files 931 931
Lines 58329 58332 +3
=======================================
+ Hits 33441 33444 +3
Misses 21835 21835
Partials 3053 3053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7346
Why are the changes needed?
The sandbox currently uses fixed port mappings by default. This becomes an issue when those ports are already occupied on the local machine, making it difficult to start the sandbox in some development environments.
What changes were proposed in this pull request?
This PR adds support for custom sandbox port mappings through a new
--portsflag.Changes made:
Portsfield to the sandbox configuration.Example usage:
How was this patch tested?
go build ./...flytectl sandbox start --helpshows the new--portsflag correctly.Checklist