fix: adjust snackbar actions imports local file to uicore lib#1004
Merged
Conversation
…to uicore lib Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAction modules switch snackbar and related helper imports from ChangesSnackbar handler import migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…rrorMsg Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: sebastian marcet <smarcet@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR standardizes snackbar success/error utilities across the app by switching multiple action modules from the local src/actions/base-actions.js helpers to the shared implementations exported by openstack-uicore-foundation, along with a patch bump of that dependency.
Changes:
- Bumped
openstack-uicore-foundationfrom5.0.37to5.0.38. - Updated many
src/actions/*modules to importsnackbarErrorHandler,snackbarSuccessHandler,snackbarErrorMsg, andsetSnackbarMessagefromopenstack-uicore-foundation/lib/utils/actionsinstead of./base-actions. - Removed the now-redundant snackbar helper implementations from
src/actions/base-actions.js(while retaining snackbar message action types and setters/clearers).
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Bumps openstack-uicore-foundation to 5.0.38. |
yarn.lock |
Updates the resolved openstack-uicore-foundation tarball and integrity for 5.0.38. |
src/actions/base-actions.js |
Removes local snackbar helper thunks that are now sourced from the shared library. |
src/actions/admin-access-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/form-template-item-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/media-file-type-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/member-actions.js |
Switches snackbar error handler import from local base-actions to openstack-uicore-foundation. |
src/actions/page-template-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/selection-plan-actions.js |
Switches snackbar success handler import from local base-actions to openstack-uicore-foundation. |
src/actions/show-pages-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-cart-actions.js |
Switches snackbar handler + setSnackbarMessage imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-forms-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-mu-actions.js |
Switches snackbar error handler import from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-pages-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-purchases-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/sponsor-users-actions.js |
Switches snackbar handler imports (incl. snackbarErrorMsg) from local base-actions to openstack-uicore-foundation. |
src/actions/sponsorship-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/ticket-actions.js |
Switches snackbar handler imports from local base-actions to openstack-uicore-foundation. |
src/actions/track-chair-actions.js |
Switches snackbar error handler import from local base-actions to openstack-uicore-foundation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…plan saves Asserts SET_SNACKBAR_MESSAGE (type: success, code: 200) is dispatched after saveAdminAccess and saveSelectionPlan succeed, exercising the real snackbarSuccessHandler now imported from openstack-uicore-foundation instead of the removed local base-actions wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86baqq2rh
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com
Summary by CodeRabbit
SET_SNACKBAR_MESSAGEwith{ type: "success", code: 200 }.5.0.38.