fix: report maxResponseSize overflow without a double callback - #1852
Open
official-burak wants to merge 1 commit into
Open
fix: report maxResponseSize overflow without a double callback#1852official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
IncomingMessage.destroy(err) emits error, and the body parser also fails, so each path called callback() again after ETOOLARGE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxResponseSizecalledcallback()and thenres.destroy(error). Node emitserroron destroy, and the body parser also fails, socallback()ran again and printedsuperagent: double callback bug.this.calledis set.Fixes #1830
Test plan
mocha test/node/image.js test/node/inflate.js(HTTP/1 and HTTP/2)