Skip to content

deps: limit dependency ranges #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tedhtchang merged 9 commits into from
Jun 20, 2024
Merged

deps: limit dependency ranges #54

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b76df0
limit dependency ranges
anhuong Feb 23, 2024
e647586
merge changes from main
anhuong Feb 27, 2024
0ff6da3
merge changes from main branch
anhuong May 14, 2024
4359c7e
set upper limits for dependencies
anhuong May 14, 2024
c974a19
fix aim version, no need to pin to specific version
anhuong May 14, 2024
9e302ca
remove requirements file, no longer used
anhuong May 14, 2024
a05dda0
merge changes from main
anhuong Jun 20, 2024
6545ab1
deps below 1.0 have more constrained upper limit
anhuong Jun 20, 2024
33193d0
merge changes from main branch
anhuong Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flashattn_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
wheel
flash-attn
wheel>=0.42.0,<1.0
flash-attn>=2.5.3,<3.0
28 changes: 14 additions & 14 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
numpy
accelerate>=0.20.3
packaging
transformers>=4.34.1
torch
aim==3.17.5
sentencepiece
tokenizers>=0.13.3
tqdm
trl
ninja
peft>=0.8.0
datasets>=2.15.0
fire
numpy>=1.26.4,<2.0
accelerate>=0.20.3,<1.0
transformers>=4.34.1,<5.0
torch>=2.2.0,<3.0
Comment thread
tedhtchang marked this conversation as resolved.
Outdated
aim>=3.17.5,<4.0
sentencepiece>=0.1.99,<2.0
tokenizers>=0.13.3,<1.0
tqdm>=4.66.2,<5.0
trl>=0.7.10,<1.0

@gkumbhat gkumbhat Mar 7, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for libraries that are not yet 1.0, I think it is not guaranteed that there won't be any API breaking change between subversions, so it is probably better to be more conservative about their versions in range.

@gkumbhat gkumbhat Mar 7, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies less for accelerate though, since that library just never went 1.0 but is very popular, so unlikely to make such changes now without big splash.

ninja>=1.11.1.1,<2.0
peft>=0.8.0,<1.0
datasets>=2.15.0,<3.0
fire>=0.5.0,<1.0
packaging>=23.2,<24