refactor(verify): drop the unreachable unknown optimizer runs branch - #16066
Merged
figtracer merged 3 commits intoAug 19, 2026
Merged
Conversation
mkzung
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
August 7, 2026 13:08
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
stevencartavia
previously approved these changes
Aug 7, 2026
mkzung
force-pushed
the
fix/verify-drop-unknown-optimizer-runs
branch
from
August 18, 2026 17:42
3329a9b to
d595a9a
Compare
Contributor
Author
|
Rebased onto master and added a Sorry about the dismissed approvals, the rebase took them with it. The diff is unchanged apart from the new fragment. |
mablr
approved these changes
Aug 19, 2026
figtracer
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16055, which @mattsse closed because the premise was wrong: the CLI path
normalizes
optimizer_runs, so nothing user-facing was broken. This is the other optionoffered there: the branch removed, and called dead code rather than a bug.
find_mismatch_in_settingsruns only fromprint_result, whose four callers all sit inbytecode.rsand pass theConfigthat comes fromload_config. That normalizesoptimizer_runs, so it is always set by then and theNonearm cannot print.No behaviour change, so no test. The unit tests in the closed PR failed only because they
built
Configby hand and skipped config loading, which is what made the premise look true.Claude Code was used for implementation assistance, covering the code change and this
description. All changes have been reviewed, understood and manually tested by me.