Skip to content

refactor(verify): drop the unreachable unknown optimizer runs branch - #16066

Merged
figtracer merged 3 commits into
foundry-rs:masterfrom
mkzung:fix/verify-drop-unknown-optimizer-runs
Aug 19, 2026
Merged

refactor(verify): drop the unreachable unknown optimizer runs branch#16066
figtracer merged 3 commits into
foundry-rs:masterfrom
mkzung:fix/verify-drop-unknown-optimizer-runs

Conversation

@mkzung

@mkzung mkzung commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #16055, which @mattsse closed because the premise was wrong: the CLI path
normalizes optimizer_runs, so nothing user-facing was broken. This is the other option
offered there: the branch removed, and called dead code rather than a bug.

find_mismatch_in_settings runs only from print_result, whose four callers all sit in
bytecode.rs and pass the Config that comes from load_config. That normalizes
optimizer_runs, so it is always set by then and the None arm cannot print.

No behaviour change, so no test. The unit tests in the closed PR failed only because they
built Config by hand and skipped config loading, which is what made the premise look true.

Claude Code was used for implementation assistance, covering the code change and this
description. All changes have been reviewed, understood and manually tested by me.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ Changelog found

The deterministic check will validate the changed entry.

mablr
mablr previously approved these changes Aug 7, 2026

@mablr mablr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

stevencartavia
stevencartavia previously approved these changes Aug 7, 2026
@mkzung
mkzung dismissed stale reviews from mablr and stevencartavia via d595a9a August 18, 2026 17:42
@mkzung
mkzung force-pushed the fix/verify-drop-unknown-optimizer-runs branch from 3329a9b to d595a9a Compare August 18, 2026 17:42
@mkzung

mkzung commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto master and added a .changelog entry, so the two red checks are gone. The changelog gate landed after this PR opened, and cargo deny was flagging RUSTSEC-2026-0258 because the branch still pinned h2 0.4.15 while master is on 0.4.16.

Sorry about the dismissed approvals, the rebase took them with it. The diff is unchanged apart from the new fragment.

@figtracer
figtracer enabled auto-merge (squash) August 19, 2026 10:16
@figtracer
figtracer merged commit bbf7b60 into foundry-rs:master Aug 19, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Foundry Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants