fix(symbolic): reject oversized memory offsets - #16183
Open
stevencartavia wants to merge 16 commits into
Open
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
mattsse
as code owners
August 14, 2026 00:00
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
mablr
reviewed
Aug 14, 2026
mablr
requested changes
Aug 14, 2026
figtracer
reviewed
Aug 14, 2026
mablr
reviewed
Aug 14, 2026
mablr
reviewed
Aug 17, 2026
mablr
reviewed
Aug 17, 2026
mablr
requested changes
Aug 17, 2026
mablr
previously approved these changes
Aug 17, 2026
figtracer
reviewed
Aug 18, 2026
figtracer
left a comment
figtracer
left a comment
Member
There was a problem hiding this comment.
found two concrete/symbolic parity blockers and two hot-path representation costs on the current head. the full symbolic crate suite and the focused cli tests pass, but one added regression currently codifies a false proof.
mablr
previously approved these changes
Aug 18, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
I don't see other blockers, sgtm
figtracer
reviewed
Aug 19, 2026
…-memory Amp-Thread-ID: https://ampcode.com/threads/T-01a01a8e-87d2-70ec-be7e-fed27bfe3644 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # crates/evm/symbolic/src/runtime/memory.rs
mablr
reviewed
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects unrepresentable offsets for symbolic
MLOAD,MSTORE, andMSTORE8, matching concrete EVM failure behavior and preventing false passes.