fix(wallet): reject keystore names that escape the keystore directory - #16237
Merged
mablr merged 1 commit intoAug 19, 2026
Merged
Conversation
cast wallet import/new/remove/decrypt/change-password joined ACCOUNT_NAME onto the keystore directory, so ../name wrote or touched files outside it. The directory is already a separate flag. Reject names that are not a single path segment.
SashaMIT
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
August 18, 2026 17:22
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
stevencartavia
approved these changes
Aug 19, 2026
mablr
approved these changes
Aug 19, 2026
Contributor
Author
|
Thanks for the review and the merge. |
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast wallet import,new,remove,decrypt-keystore, andchange-passwordjoin ACCOUNT_NAME onto the keystore directory. Names such as../nameandnested/aliastherefore write, delete, or decrypt a file outside that directory. The directory itself is already a separate flag (--keystore-dir/cast wallet new <DIR>).This rejects names that are not a single path segment, next to the existing reserved
.touchidsuffix check. Ordinary names such asdevandtestAccountstill work.This PR was written with AI assistance (Cursor agent). I reviewed the defect, the guard, and the tests.