Repository navigation
Conversation
Some hosts take the keyboard off a plugin's window and offer keys through IPlugView instead, which is the only way a plugin sees them there. CLAP has no key event to forward those to, by design, so WrappedView's onKeyDown and onKeyUp were stubs returning kResultFalse and a wrapped VST3 could not have keyboard shortcuts at all. Adds CLAP_PLUGIN_AS_VST3_KEYS, a plugin extension beside the wrapper's existing clap-wrapper-specific ones, carrying IPlugView's own arguments: the character the key produced, a VirtualKeyCodes value for a key that produced none, and KeyModifier bits. WrappedView queries it and reports kResultTrue only when the plugin says it used the key, so a host's own key handling is not blocked. A plugin that does not implement the extension behaves exactly as before.
Author
|
Found a different way to make this work, using JUCE's hwnd listener method. Extension not needed, so closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some hosts take the keyboard off a plugin's window and offer keys through
IPlugViewinstead, which is the only way a plugin sees them there. CLAP has no key event to forward those to, by design, soWrappedView'sonKeyDown()andonKeyUp()were stubs returningkResultFalseand a wrapped VST3 could not have keyboard shortcuts at all.Adds
CLAP_PLUGIN_AS_VST3_KEYS, a plugin extension beside the wrapper's existingclap-wrapper-specific ones, carryingIPlugView's own arguments: the character the key produced, aVirtualKeyCodesvalue for a key that produced none, andKeyModifierbits.WrappedViewqueries it and reportskResultTrueonly when the plugin says it used the key, so a host's own key handling is not blocked. A plugin that does not implement the extension behaves exactly as before.Assisted-By: Claude Opus 5 noreply@anthropic.com