Repository navigation
Standalone: never activate a plugin at sample rate 0 - #589
Merged
defiantnerd merged 1 commit intoOct 8, 2026
Merged
Conversation
activatePlugin now refuses a non-positive sample rate or an empty block range. With no output device, a plugin that called request_restart was activated at 0 Hz on macOS. Both the macOS and Windows restart handlers now only reactivate a plugin that is currently active. Assisted-by: Claude Opus 5.5
defiantnerd
approved these changes
Oct 8, 2026
defiantnerd
left a comment
defiantnerd
left a comment
Collaborator
There was a problem hiding this comment.
Yeah - perhaps we need a little bit more error handling, the also displays in the Window itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
activatePluginaccepted any sample rate. On macOS, arequest_restartfrom a plugin reactivated it unconditionally, unlike therequest_processbranch next to it. With no output device, that meantactivate(0, …), which risks a divide-by-zero in the plugin.activatePluginnow refuses a non-positive sample rate or an empty block range, before deactivating anything.This is P0-3 of the standalone-revisited list. Linux doesn't service restart requests at all yet; that is LIN-N1, separate from this.
Tested