Repository navigation
AUv2: take a request_resize made inside gui->create() as the view's initial size - #591
Closed
busticated wants to merge 1 commit into
Closed
busticated wants to merge 1 commit into
busticated wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #582.
initWithAUv2:runsgui->create()before[super initWithFrame:], so arequest_resize()from insidecreate()callssetFrame:on an uninitialized view causing AppKit to throw. With the changes here, whilecreate()runs,setFrame:stores the requested size andinitWithAUv2:uses it as the initial frame.Tested with
pluginval's (v1.0.4) AU editor test on anice-plug-eguiplugin - it aborts onv0.16.0without this change and passes with it.All CI jobs pass on
next- see here: https://github.com/busticated/clap-wrapper/actionsHappy to address any feedback - hope it helps 🙏 👍