Skip to content

Console: process multiple targets #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webwarrior-ws wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Console: process multiple targets #805

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
029952e
Console: process multiple targets
webwarrior-ws Dec 24, 2025
ee14b6d
GithubCI: lint single file in .NET 8 and 10 jobs
webwarrior-ws Dec 22, 2025
d729e9a
GithubCI: remove --framework argument
webwarrior-ws Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 34 additions & 20 deletions src/FSharpLint.Console/Program.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,30 +159,44 @@ let private start (arguments:ParseResults<ToolArgs>) (toolsPath:Ionide.ProjInfo.
Configuration = configParam
ReportLinterProgress = Some (parserProgress output) }

let target = lintArgs.GetResult Target
let fileType = lintArgs.TryGetResult File_Type |> Option.defaultValue (inferFileType target)
let targets = lintArgs.GetResults Target

let fileType =
match lintArgs.TryGetResult File_Type with
| Some fileType ->
fileType
| None ->
match targets |> List.map inferFileType |> List.distinct with
| [ inferredType ] ->
inferredType
| inferredTypes ->
handleError $"""Given targets were inferred to have multiple types: {inferredTypes}.
Specify file type by passing --file-type argument."""
exit exitCode
Comment thread
knocte marked this conversation as resolved.
failwith "Unreachable"

try
let lintResult =
match fileType with
| FileType.File -> Lint.lintFile lintParams target
| FileType.Source -> Lint.lintSource lintParams target
| FileType.Solution -> Lint.lintSolution lintParams target toolsPath
| FileType.Wildcard ->
output.WriteInfo "Wildcard detected, but not recommended. Using a project (slnx/sln/fsproj) can detect more issues."
let files = expandWildcard target
if List.isEmpty files then
output.WriteInfo $"No files matching pattern '%s{target}' were found."
LintResult.Success List.empty
else
output.WriteInfo $"Found %d{List.length files} file(s) matching pattern '%s{target}'."
Lint.lintFiles lintParams files
| FileType.Project
| _ -> Lint.lintProject lintParams target toolsPath
handleLintResult lintResult
for target in targets do
let lintResult =
match fileType with
| FileType.File -> Lint.lintFile lintParams target
| FileType.Source -> Lint.lintSource lintParams target
| FileType.Solution -> Lint.lintSolution lintParams target toolsPath
| FileType.Wildcard ->
output.WriteInfo "Wildcard detected, but not recommended. Using a project (slnx/sln/fsproj) can detect more issues."
let files = expandWildcard target
if List.isEmpty files then
output.WriteInfo $"No files matching pattern '%s{target}' were found."
LintResult.Success List.empty
else
output.WriteInfo $"Found %d{List.length files} file(s) matching pattern '%s{target}'."
Lint.lintFiles lintParams files
| FileType.Project
| _ -> Lint.lintProject lintParams target toolsPath
handleLintResult lintResult
with
| exn ->
let target = if fileType = FileType.Source then "source" else target
let target = if fileType = FileType.Source then "source" else String.Join(", ", targets)
handleError
$"Lint failed while analysing %s{target}.{Environment.NewLine}Failed with: %s{exn.Message}{Environment.NewLine}Stack trace: {exn.StackTrace}"
| _ -> ()
Expand Down