Skip to content

Fix CI env loading and flaky API token regeneration test #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syyspe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CI env loading and flaky API token regeneration test #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest
env:
NODE_ENV: test

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions tests/blog-app.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ test.describe("Blog Application", () => {
// Generate new token without reloading
await page.getByTestId("generate-token-button").click()

// Wait for token to potentially change
await page.waitForTimeout(500)
// Wait for the token text to actually change (server action + revalidate)
await expect(page.getByTestId("api-token")).not.toHaveText(firstToken!)
const secondToken = await page.getByTestId("api-token").textContent()

// Tokens should be different
Expand Down