ENH: Serialize null interface refs as literals - #268
Open
aminemanai2003 wants to merge 1 commit into
Open
Conversation
aminemanai2003
force-pushed
the
agent/serialize-null-interface-literal
branch
from
August 9, 2026 00:00
a05a960 to
7cf84d9
Compare
aminemanai2003
marked this pull request as ready for review
August 9, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interfacetuples instead of storing their null objects indata.pickleRoot cause
InterfaceRefEncoderonly accepted valid interfaces. A reference to deleted Cells or Spaces therefore fell through toPickleEncoder, producing an opaque entry such as("Pickle", 1)in the generated source.Null interfaces now use an explicit representation such as
("Interface", (None, "Cells")). The outer tuple remains a two-element interface reference, retaining the existing automatic-reference restoration behavior when a deleted target can no longer satisfy a relative reference.Validation
python -m pytest modelx/tests/serialize -q— 250 passed, 2 skippedpython -m pytest modelx/tests -q— 1221 passed, 6 skippedgit diff --checkCloses #226