Repository navigation
feat: add foreignConnections and runOutsideTransaction; only reject foreign connections in open transactions - #826
Merged
Merged
Conversation
…oreign connections in open transactions
🦋 Changeset detectedLatest commit: 3d35695 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes false positives of
UnexpectedForeignConnectionErrorand replacesdangerouslyAllowForeignConnectionswith a non-booleanforeignConnectionsoption.Only reject foreign connections while the transaction is open
Async work that is started inside of a transaction inherits the transaction's async context, even when it runs after the transaction has ended. Previously, any query that such work ran on another connection raised
UnexpectedForeignConnectionError, e.g. from:COMMITcommitorrollbackevent listener, which runs inside of the transaction's contextThe transaction context now tracks whether the transaction is open: it opens after
START TRANSACTION(including when the transaction is retried) and closes afterCOMMITorROLLBACK, before the events are emitted. The check applies only while the transaction is open.runOutsideTransactionRuns a routine outside of the surrounding transaction, so that its queries can use other connections while the transaction is open, e.g. an audit log entry that must persist even if the transaction is rolled back:
foreignConnectionsforeignConnections: "reject"(default) throwsUnexpectedForeignConnectionError;foreignConnections: "allow"runs the query outside of the transaction.dangerouslyAllowForeignConnections: truekeeps working as a deprecated alias offoreignConnections: "allow", andforeignConnectionstakes precedence when both are provided. Any other value throwsInvalidConfigurationError.Tests
COMMIT, fromcommitandrollbacklisteners, inside of a retried transaction (still rejected), withrunOutsideTransaction(not rolled back), and withforeignConnections: "allow".foreignConnections: default, deprecated alias, precedence, and an invalid value.