Repository navigation
docs: netrc overwrite, clean force-push, changelog sort pitfalls - #16
Draft
cursor[bot] wants to merge 2 commits into
Draft
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…alls Capture verified consumer/maintainer surprises: .netrc is fully rewritten, git-cli force-pushes the base SHA when the version tree is clean, highestLevel can be inflated by newer changelog sections, and publish monorepo tag matching throws on unknown package names. Co-authored-by: Mohamed <garlobrian52@users.noreply.github.com>
Point the runtime startup list at the auth doc so the writeFile behavior is not easy to miss when scanning dispatch order. Co-authored-by: Mohamed <garlobrian52@users.noreply.github.com>
|
PR author is not in the allowed authors list. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation follow-up after merged PR #15. Captures additional source-verified pitfalls that were still easy to miss when scanning existing engineering docs.
Does not redo open PR #11 (
docs/maintainer-release.md/action.ymlbranchdefault).Docs added/updated
docs/auth-and-publishing.md—$HOME/.netrcis fully rewritten (writeFile) with fixedlogin github-actions[bot]; multi-host entries are lost for the rest of the job.docs/push-changes-internals.md— git-cli always force-pushes afterprepareBranchreset; a clean version tree publishes the base SHA and can empty/auto-close the Version Packages PR.docs/action-runtime.md—highestLevelwalks from file start (can be inflated by newer### Major Changessections);preStateonly surfaced whenmode === "pre"; monorepo publish throws on unknownNew tag:names and creates Releases viaPromise.all.docs/troubleshooting.md— symptoms for clean force-push, sort-order pollution, pre-exit, unknown package, and.netrcclobber.Codepaths covered
src/index.ts→.netrcwriteFile,readChangesetStatedispatchsrc/git.ts→prepareBranch+pushChangesclean/dirty force-pushsrc/utils.ts→getChangelogEntry/highestLevelsrc/readChangesetState.ts→ pre-mode vs exitsrc/run.ts→runPublishmonorepo tag match + parallel releasesKnowledge gaps addressed
.netrcwas merely “written for auth”; it overwrites the whole file every run.highestLevelis computed “while walking that slice”; verified against source (and a local newest-first fixture) that newer sections above the target version can inflate sort order.Verified against
src/index.ts,src/git.ts,src/utils.ts,src/readChangesetState.ts, andsrc/run.ts.Summary by cubic
Clarifies auth and release behavior to prevent surprises: the action overwrites
$HOME/.netrc,git-clican force-push a clean tree and empty the PR, and changelog sorting can be skewed by newer sections; also documents monorepo tag matching and release concurrency.auth-and-publishing.md—.netrcis fully rewritten with a singlegithub.commachine (login github-actions[bot]); still written withcommitMode: github-api; note to recreate multi-host files after the action.action-runtime.md— startup now calls out the.netrcoverwrite;preStateis only surfaced whenmode === "pre";highestLevelwalks from the file start and can inflate sort order; monorepo publish throws on unknownNew tag:names and creates releases in parallel.push-changes-internals.md—git-clialways force-pushes; when the tree is clean it pushes the base SHA, which can empty or auto-close the Version Packages PR; comparison table updated.troubleshooting.md— adds symptoms and fixes for unknown package tags,.netrcclobber, clean force-push PR closure, inflated changelog ordering, and pre-exit behavior.Written for commit 72ca139. Summary will update on new commits.