Repository navigation
Name 42 new water heaters and capability 103117 from the vendor catalogue - #198
Open
mathieuletyrant wants to merge 1 commit into
Open
mathieuletyrant wants to merge 1 commit into
mathieuletyrant wants to merge 1 commit into
Conversation
…ogue A local run of scripts/check_capability_catalogue.py on 2026-10-26 found both catalogues moved: 407 capabilities (one new) and 2162 models (43 added, 180 gone). Products are unchanged at 123. Capability 103117 is ROOM_CentralHeatingEnable in the catalogue: a 0/1 read-write value, "Central Heating mode activation status". No device has reported it, so it gets the unverified row: STRING, diagnostic, disabled by default, named central_heating_enable in every language. Models 3647-3697 are Calypso split and Flat Evo / Malicio / Vertigo / Onix / Lineo electric water heaters, named as the vendor spells them. All carry productId 0, so nothing goes into PRODUCT_ID_RUNS. 3701, "WATERDROP 2 DEFAULT", is a firmware slot and is left out, but it is past 3699, so the snapshot and capability test ranges now reach it. The 180 removed models (595-1037 radiators, TAHUAL 1636-1638) are not recorded: the committed .jsonl keeps them, and model_catalogue.py still names them. Whether to drop them is the maintainer's call. No hardware checked any of this; none of it is a Navizone or THZONE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalogue read on 2026-10-26 (run locally by the maintainer): 407 capabilities, 2162 models, 123 products.
What this adds
ROOM_CentralHeatingEnable, 0/1, read-write). It gets the unverified row: STRING, diagnostic, disabled by default, translated in every language.productId0, so there are no product-id runs.WATERDROP 2 DEFAULTis a slot and is not named. The model id range is widened to 3702 so it is covered.Needs a decision: 180 models removed by Atlantic
They are not recorded in this PR: the
.jsonlandmodel_catalogue.pystill have them. They break down as:productId0productId53The skill's rule says a model dropped from the catalogue can still be on somebody's wall, so the code should keep them. @mathieuletyrant: should the
.jsonlrecord the removal, which would require the sync test to accept ids that are no longer in the catalogue?No hardware checked any of this.