Skip to content

fix: reject trailing invocation bytes #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ukint-vs merged 8 commits into from
Aug 31, 2026
Merged

fix: reject trailing invocation bytes #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d31d53
fix: reject trailing invocation bytes
ukint-vs Aug 28, 2026
c86a20d
fix: satisfy new chunks_exact clippy lint
ukint-vs Aug 31, 2026
c6b4556
fix: reject trailing invocation parameters
ukint-vs Aug 31, 2026
13c2afe
chore: normalize strict decoder formatting
ukint-vs Aug 31, 2026
c285d1c
chore: match rustfmt line wrapping
ukint-vs Aug 31, 2026
0bb98e6
chore: allow intentional unit error in inspector
ukint-vs Aug 31, 2026
3d299a4
test: update strict decoder snapshots
ukint-vs Aug 31, 2026
43e21cf
test: update ethexe strict decoder snapshots
ukint-vs Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/inspector/app/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ impl InspectorService {

/// Proxy call to validator.validate_even(7)
#[export(unwrap_result)]
#[allow(clippy::result_unit_err)]
pub async fn test_even_panic(&self) -> Result<u32, ()> {
self.validator.validate_even(7).await.unwrap()
}
Expand Down
2 changes: 1 addition & 1 deletion ...ros-tests/tests/snapshots/program_insta__filters_program_level_dispatch_by_transport.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ pub mod wasm {
}
match header.entry_id() {
1u16 => {
let (): () = sails::Decode::decode(&mut input)
let (): () = sails::scale_codec::DecodeAll::decode_all(&mut input)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
8 changes: 6 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_ctors_meta_with_docs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (p1, p2): (u32, String) = sails::Decode::decode(&mut input)
let (p1, p2): (u32, String) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand All @@ -141,7 +143,9 @@ pub mod wasm {
)
}
1u16 => {
let (p2, p1): (String, u32) = sails::Decode::decode(&mut input)
let (p2, p1): (String, u32) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
2 changes: 1 addition & 1 deletion ...napshots/program_insta__generates_handle_for_multiple_services_with_non_empty_routes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (): () = sails::Decode::decode(&mut input)
let (): () = sails::scale_codec::DecodeAll::decode_all(&mut input)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
2 changes: 1 addition & 1 deletion ...ests/tests/snapshots/program_insta__generates_handle_for_services_with_unwrap_result.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (): () = sails::Decode::decode(&mut input)
let (): () = sails::scale_codec::DecodeAll::decode_all(&mut input)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
2 changes: 1 addition & 1 deletion ...ts/snapshots/program_insta__generates_handle_for_single_service_with_non_empty_route.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (): () = sails::Decode::decode(&mut input)
let (): () = sails::scale_codec::DecodeAll::decode_all(&mut input)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
4 changes: 3 additions & 1 deletion rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_handle_with_crate_path.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (): () = sails_rename::Decode::decode(&mut input)
let (): () = sails_rename::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails_rename::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
8 changes: 6 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_init_for_multiple_ctors.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (p1, p2): (u32, String) = sails::Decode::decode(&mut input)
let (p1, p2): (u32, String) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand All @@ -135,7 +137,9 @@ pub mod wasm {
)
}
1u16 => {
let (p2, p1): (String, u32) = sails::Decode::decode(&mut input)
let (p2, p1): (String, u32) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_init_for_no_ctor.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (): () = sails::Decode::decode(&mut input)
let (): () = sails::scale_codec::DecodeAll::decode_all(&mut input)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
4 changes: 3 additions & 1 deletion rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_init_for_single_ctor.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (p1, p2): (u32, String) = sails::Decode::decode(&mut input)
let (p1, p2): (u32, String) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
8 changes: 6 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/program_insta__generates_init_with_unwrap_result.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ pub mod wasm {
}
match header.entry_id() {
0u16 => {
let (p1, p2): (u32, String) = sails::Decode::decode(&mut input)
let (p1, p2): (u32, String) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand All @@ -137,7 +139,9 @@ pub mod wasm {
)
}
1u16 => {
let (p2, p1): (String, u32) = sails::Decode::decode(&mut input)
let (p2, p1): (String, u32) = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.unwrap_or_else(|_| sails::gstd::unknown_input_panic(
"Unknown request",
input,
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_allow_attrs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ impl SomeServiceExposure<SomeService> {
1u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__ThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -107,7 +107,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_basics.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl SomeServiceExposure<SomeService> {
1u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__ThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -104,7 +104,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_crate_path.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl SomeServiceExposure<SomeService> {
1u16,
) if id
== <self::SomeService as sails_rename::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ThisParams = sails_rename::scale_codec::Decode::decode(
let request: some_service_meta::__ThisParams = sails_rename::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -104,7 +104,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails_rename::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails_rename::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails_rename::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_docs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ impl SomeServiceExposure<SomeService> {
1u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__ThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -107,7 +107,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_events.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl MyServiceWithEventsExposure<MyServiceWithEvents> {
0u16,
) if id
== <self::MyServiceWithEvents as sails::meta::Identifiable>::INTERFACE_ID => {
let request: my_service_with_events_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: my_service_with_events_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand All @@ -96,7 +96,7 @@ impl MyServiceWithEventsExposure<MyServiceWithEvents> {
1u16,
) if id
== <self::MyServiceWithEvents as sails::meta::Identifiable>::INTERFACE_ID => {
let request: my_service_with_events_meta::__ThisParams = sails::scale_codec::Decode::decode(
let request: my_service_with_events_meta::__ThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_explicit_dual_export.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DualMethodParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DualMethodParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_explicit_scale_only.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ScaleMethodParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__ScaleMethodParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_export.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl SomeServiceExposure<SomeService> {
1u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__ThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__ThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -108,7 +108,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoSomethingParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoSomethingParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_extends.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ impl SomeServiceExposure<SomeService> {
0u16,
) if id
== <self::SomeService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
4 changes: 2 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_extends_and_lifetimes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl<'a> ExtendedWithLifetimeExposure<ExtendedWithLifetime<'a>> {
== <self::ExtendedWithLifetime<
'a,
> as sails::meta::Identifiable>::INTERFACE_ID => {
let request: extended_with_lifetime_meta::__ExtendedNameParams = sails::scale_codec::Decode::decode(
let request: extended_with_lifetime_meta::__ExtendedNameParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -115,7 +115,7 @@ impl<'a> ExtendedWithLifetimeExposure<ExtendedWithLifetime<'a>> {
== <self::ExtendedWithLifetime<
'a,
> as sails::meta::Identifiable>::INTERFACE_ID => {
let request: extended_with_lifetime_meta::__NameParams = sails::scale_codec::Decode::decode(
let request: extended_with_lifetime_meta::__NameParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_lifetimes_and_events.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ where
'a,
T,
> as sails::meta::Identifiable>::INTERFACE_ID => {
let request: my_generic_events_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: my_generic_events_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
2 changes: 1 addition & 1 deletion rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_lifetimes_and_generics.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ where
T,
U,
> as sails::meta::Identifiable>::INTERFACE_ID => {
let request: some_service_meta::__DoThisParams = sails::scale_codec::Decode::decode(
let request: some_service_meta::__DoThisParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
10 changes: 5 additions & 5 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_methods_with_lifetimes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl ReferenceServiceExposure<ReferenceService> {
0u16,
) if id
== <self::ReferenceService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: reference_service_meta::__AddByteParams = sails::scale_codec::Decode::decode(
let request: reference_service_meta::__AddByteParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand All @@ -119,7 +119,7 @@ impl ReferenceServiceExposure<ReferenceService> {
1u16,
) if id
== <self::ReferenceService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: reference_service_meta::__BakedParams = sails::scale_codec::Decode::decode(
let request: reference_service_meta::__BakedParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand All @@ -145,7 +145,7 @@ impl ReferenceServiceExposure<ReferenceService> {
3u16,
) if id
== <self::ReferenceService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: reference_service_meta::__IncrParams = sails::scale_codec::Decode::decode(
let request: reference_service_meta::__IncrParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down Expand Up @@ -183,7 +183,7 @@ impl ReferenceServiceExposure<ReferenceService> {
2u16,
) if id
== <self::ReferenceService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: reference_service_meta::__FirstByteParams = sails::scale_codec::Decode::decode(
let request: reference_service_meta::__FirstByteParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand All @@ -209,7 +209,7 @@ impl ReferenceServiceExposure<ReferenceService> {
4u16,
) if id
== <self::ReferenceService as sails::meta::Identifiable>::INTERFACE_ID => {
let request: reference_service_meta::__LastByteParams = sails::scale_codec::Decode::decode(
let request: reference_service_meta::__LastByteParams = sails::scale_codec::DecodeAll::decode_all(
&mut input,
)
.expect("Failed to decode params");
Expand Down
Loading