GPU-2187: JSON type - #790
Merged
Merged
Conversation
plyhun
requested review from
deckdom and
npomaroli
and removed request for
npomaroli
April 30, 2026 14:45
plyhun
commented
Jul 22, 2026
| <!-- dd.MM.YYYY --> | ||
| <alohaeditor.date>14.07.2026</alohaeditor.date> | ||
| <!-- Dependency to Mesh Client Version. Tested Mesh Server Version is defined with com.gentics.contentnode.testutils.mesh.MeshContext.TESTED_MESH_VERSION --> | ||
| <mesh.version>3.2.12</mesh.version> |
Contributor
Author
There was a problem hiding this comment.
Replace with 3.3.0* when upmerged.
This reverts commit 4ea4694.
deckdom
reviewed
Aug 6, 2026
npomaroli
reviewed
Sep 7, 2026
| * @param tag | ||
| * @throws NodeException | ||
| */ | ||
| private static void validateObjectTagObject(EditableFactoryObjectTag tag) throws NodeException { |
Contributor
Author
There was a problem hiding this comment.
The only place I was able to find and test upon.
Member
There was a problem hiding this comment.
What about templatetags and contenttags?
Contributor
Author
There was a problem hiding this comment.
Will need an advice on the test possibilities. The functionality fix is trivial.
Member
There was a problem hiding this comment.
Testing is similar to testing with objecttags. For templatetags you change the tag in a template, for contenttags you change the tag in a content (of a page).
npomaroli
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.