Skip to content

PoC: streaming response in ProxyResource #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netwarex wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

PoC: streaming response in ProxyResource #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion cms-core/src/main/java/com/gentics/contentnode/rest/resource/impl/proxy/ProxyResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import jakarta.ws.rs.core.Response;
import jakarta.ws.rs.core.Response.ResponseBuilder;
import jakarta.ws.rs.core.Response.Status;
import jakarta.ws.rs.core.StreamingOutput;
import jakarta.ws.rs.core.UriInfo;

import org.apache.commons.httpclient.Header;
Expand Down Expand Up @@ -399,6 +400,33 @@ protected <T extends HttpMethodBase> Response forward(T method, Consumer<T> prep
}
responseBuilder.header(name, header.getValue());
}
return responseBuilder.entity(method.getResponseBodyAsStream()).build();

responseBuilder.header("X-Proxy-Streaming", "1");

@netwarex netwarex Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker: lets callers verify the streaming patch is loaded


InputStream responseBodyStream = method.getResponseBodyAsStream();
if (responseBodyStream == null) {
method.releaseConnection();
return responseBuilder.build();
}

StreamingOutput streamingBody = output -> {

@netwarex netwarex Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy the upstream body chunk by chunk, flushing after every read so each chunk reaches the socket immediately instead of accumulating in the servlet output buffer until the upstream response completes.

try {
byte[] buffer = new byte[8192];
int read;
while ((read = responseBodyStream.read(buffer)) >= 0) {
if (read > 0) {
output.write(buffer, 0, read);
output.flush();
}
}
} finally {
try {
responseBodyStream.close();
} catch (IOException ignored) {
}
method.releaseConnection();
}
};
return responseBuilder.entity(streamingBody).build();
}
}