Purge (micro)schema versions - #1753
Open
plyhun wants to merge 21 commits into
Open
Conversation
plyhun
commented
Mar 24, 2026
| @@ -1,140 +0,0 @@ | |||
| package com.gentics.mesh.core.project.maintenance; | |||
Contributor
Author
There was a problem hiding this comment.
Completely unused. The correct implementation of ProjectVersionPurgeHandler is loaded elsewhere.
plyhun
commented
Mar 24, 2026
| // truncate the error detail message to the max length for the error detail property | ||
| setErrorDetail(truncateStackTrace(stackTrace)); | ||
| setErrorMessage(e.getMessage()); | ||
| setErrorMessage(StringUtils.substring(e.getMessage(), 0, 255)); |
plyhun
commented
Mar 24, 2026
| } | ||
| if (version.getPreviousVersion() != null) { | ||
| version.getPreviousVersion().setNextVersion(null); | ||
| version.getPreviousVersion().setNextVersion(version.getNextVersion()); |
Contributor
Author
There was a problem hiding this comment.
Bug in version removal. Worth porting to hotfix.
plyhun
commented
Mar 24, 2026
| if (status != null) { | ||
| boolean allMatching = true; | ||
| for (JobResponse info : response.getData()) { | ||
| if (before.getData().stream().anyMatch(j -> Objects.equal(j.getUuid(), info.getUuid()))) { |
Contributor
Author
There was a problem hiding this comment.
We count only new jobs.
plyhun
commented
Mar 24, 2026
|
|
||
| @Parameters(name = "{index}: {0}") | ||
| public static Collection<Object[]> parameters() { | ||
| return List.of(new Object[] { 0 }, new Object[] { 1 }, new Object[] { 2 }, new Object[] { 5 }, new Object[] { 8 }); |
Contributor
Author
There was a problem hiding this comment.
Random meaningful numbers, including 1 (nothing to clean) and 0 (no changes).
plyhun
commented
Mar 24, 2026
| } | ||
|
|
||
| @Test | ||
| @Category({FailingTests.class}) |
Contributor
Author
There was a problem hiding this comment.
Not anymore failing.
Updated the changelog entry to specify that the purge process saves storage resources.
npomaroli
requested changes
Mar 30, 2026
…terized requests.
Updated the purge process for schemas and microschemas to use new REST API endpoints, allowing for parameterization by schema name/UUID filters.
plyhun
commented
Apr 1, 2026
| @@ -0,0 +1,2 @@ | |||
| Core: Now it is possible to purge empty (micro)schema versions automatically, via new background jobs. This will save storage and runtime resources of the database. | |||
| The purge process is triggered via REST API `POST /utilities/purge/schemas/versions` and `POST /utilities/purge/microschemas/versions` respectively, and can be parameterized by schema name/UUID filters. | |||
Contributor
Author
There was a problem hiding this comment.
The calls have to be moved to /utilities because of POST /schemas/{uuid} taking over the /schemas/purge calls
plyhun
commented
Apr 1, 2026
| endpoint.exampleRequest(microschemaExamples.getGeolocationMicroschemaCreateRequest()); | ||
| endpoint.exampleResponse(OK, utilityExamples.createValidationResponse(), "The validation report"); | ||
| endpoint.blockingHandler(rc -> { | ||
| private void addValidationHandler() { |
plyhun
commented
Apr 1, 2026
| /** | ||
| * Set the job start query. | ||
| */ | ||
| void setQuery(String query); |
Contributor
Author
There was a problem hiding this comment.
General purpose job query.
plyhun
commented
Apr 2, 2026
| purgeSchemaVersionsEndpoint.method(POST); | ||
| purgeSchemaVersionsEndpoint.description("Purge the unused schema versions."); | ||
| purgeSchemaVersionsEndpoint.consumes(APPLICATION_JSON); | ||
| purgeSchemaVersionsEndpoint.exampleRequest(miscExamples.createNameOrUuidsRequest()); |
Contributor
Author
There was a problem hiding this comment.
I favored a POST body over query parameters request, as it can hold more values, if required. Matter of a discussion though.
plyhun
commented
Apr 20, 2026
|
|
||
| @Override | ||
| public void beforeVersionDeletedFromDatabase(HibMicroschemaVersion version) { | ||
| HibernateTx tx = HibernateTx.get(); |
Contributor
Author
There was a problem hiding this comment.
It really looks to me that no one had ever tested the deletion of microschema versions until this moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
To same database time/space, we could delete empty versions.
Checklist
General
/CHANGELOG.adocOn API Changes