Hotfix 3.2.x sup 19907 - #1782
Open
plyhun wants to merge 8 commits into
Open
Conversation
plyhun
commented
Aug 19, 2026
| @@ -1,48 +0,0 @@ | |||
| package com.gentics.mesh.cache; | |||
|
|
|||
plyhun
commented
Aug 19, 2026
| }); | ||
| result.putAll(resultStream.distinct().collect(Collectors.toMap(ContentKey::fromContent, Function.identity()))); | ||
| result.putAll(resultStream.distinct().collect(Collectors.toMap( | ||
| content -> ContentKey.fromContentUUIDAndVersionUUID( |
Contributor
Author
There was a problem hiding this comment.
Improvement 1. For every content found, a schema version has been requested just to take its UUID and reference type. Since we already have this info in the content, this request can be eliminated fully.
plyhun
commented
Aug 19, 2026
| .put("hibernate.cache.use_query_cache", Boolean.TRUE.toString()) | ||
| .put("hibernate.cache.use_second_level_cache", Boolean.TRUE.toString()); | ||
| .put("hibernate.cache.use_second_level_cache", Boolean.TRUE.toString()) | ||
| .put("hibernate.criteria.plan_cache_enabled", Boolean.TRUE.toString()) |
Contributor
Author
There was a problem hiding this comment.
Improvement 2. Fine tune query caches to support big payloads.
plyhun
commented
Aug 19, 2026
| private void setStatisticsOptions(ImmutableMap.Builder<String, Object> optionBuilder) { | ||
| optionBuilder.put(AvailableSettings.GENERATE_STATISTICS, options.getStorageOptions().isGenerateStatistics()); | ||
| optionBuilder.put(AvailableSettings.LOG_SLOW_QUERY, Long.toString(options.getStorageOptions().getSlowSqlThreshold())); | ||
| optionBuilder.put(AvailableSettings.USE_SQL_COMMENTS, options.getStorageOptions().isGenerateStatistics()); |
Contributor
Author
There was a problem hiding this comment.
Logging improvement.
plyhun
commented
Aug 19, 2026
| .collect(collectingByNodeWithLanguageFallback(languageTags)); | ||
|
|
||
| return contentByNode.values().stream().map(c -> new NodeContent(c.getNode(), c, languageTags, type)); | ||
| return HibernateTx.get().contentDao().getNodes(schemaContent).map(p -> new NodeContent(p.getValue(), p.getKey(), languageTags, type)); |
Contributor
Author
There was a problem hiding this comment.
Improvement 3. Each c.getNode() throws a distinct database request. Those could be batch fetched.
plyhun
commented
Aug 19, 2026
| <class>com.gentics.mesh.hibernate.data.domain.HibVersionPurgeJobImpl</class> | ||
| <class>com.gentics.mesh.hibernate.data.domain.MeshVersionEntityImpl</class> | ||
|
|
||
| <shared-cache-mode>DISABLE_SELECTIVE</shared-cache-mode> |
Contributor
Author
There was a problem hiding this comment.
Improvement 4. By default the entities are not 2nd level cached. We make them cacheable here, except those explicitly marked with setCacheable(false).
plyhun
commented
Aug 19, 2026
| <vertx.version>5.0.12</vertx.version> | ||
| <dagger.version>2.56.2</dagger.version> | ||
| <hibernate.version>7.1.8.Final</hibernate.version> | ||
| <hibernate.version>7.1.35.Final</hibernate.version> |
Contributor
Author
There was a problem hiding this comment.
Improvement 5. Apply fixes of Hibernate self for the current minor version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Performance improvements over complex node data fetch
Checklist
General
/CHANGELOG.adocOn API Changes