Skip to content

Rename log.txt to screen-output in some tests#6996

Merged
gassmoeller merged 1 commit into
geodynamics:mainfrom
anne-glerum:rename_test_logs
Jun 4, 2026
Merged

Rename log.txt to screen-output in some tests#6996
gassmoeller merged 1 commit into
geodynamics:mainfrom
anne-glerum:rename_test_logs

Conversation

@anne-glerum

Copy link
Copy Markdown
Contributor

Some tests have a log.txt reference file, but not a screen-output file. This PR renames the log.txt to screen-output.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@gassmoeller

Copy link
Copy Markdown
Member

/rebuild

@gassmoeller gassmoeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I could have sworn our tester woud complain if it doesnt find a screen-output file (I think that happened to me when adding new tests). It looks like we need to take another look at our tester infrastructure, I opened #6998 to keep track of this.

This PR makes sense of course, lets see if the tester is now failing for these tests because it actually compares the output to the correct file.

@gassmoeller gassmoeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, interesting. It seems the tester was running these tests already, even before this PR

(see e.g. this output for this PR: https://github.com/geodynamics/aspect/actions/runs/26938387023/job/79473538940?pr=6996#step:5:4210

and this output for #6992: https://github.com/geodynamics/aspect/actions/runs/26771570828/job/78912126379?pr=6992#step:5:4212)

Either way, we should be consistent about the name of this file.

Eventually, we should just rename all screen-output files to log.txt and only use log.txt everywhere. The name screen-output is a leftover from very early in ASPECTs development.

@gassmoeller gassmoeller merged commit e294afb into geodynamics:main Jun 4, 2026
8 of 9 checks passed
@anne-glerum anne-glerum deleted the rename_test_logs branch June 4, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants