Update latest jupyter-ydoc + JupyterLab + Galata

[nakul-py]

Description

Checklist

• PR has a descriptive title and content.
• PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
• PR has one of the labels: documentation, bug, enhancement, feature, maintenance
• Checks are passing.
  Failing lint checks can be resolved with:
  • pre-commit run --all-files
  • jlpm run lint
• If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

---

📚 Documentation preview: https://jupytergis--1538.org.readthedocs.build/en/1538/
💡 JupyterLite preview: https://jupytergis--1538.org.readthedocs.build/en/1538/lite
💡 Specta preview: https://jupytergis--1538.org.readthedocs.build/en/1538/lite/specta

[github-actions]

👈 Launch a Binder on branch nakul-py/jupytergis/test-build-fix

[martinRenou]

Thanks @nakul-py ! I think this is going in the right direction

[martinRenou]

friendly ping @davidbrochart

[davidbrochart]

Why are tests failing?

[martinRenou]

Why are tests failing?

We need to make dirty a getter. I guess we need a setter as well? I assume when the document is saved, the content provider will set this property to false?

[davidbrochart]

Since JupyterGISDoc extends YDocument, you don't have to redefine dirty?

[nakul-py]

Since JupyterGISDoc extends YDocument, you don't have to redefine dirty?

Yes i think same, instead we can do

 get dirty(): boolean {
    return super.dirty;
  }

[davidbrochart]

Or nothing at all :)

[nakul-py]

Got this new error

———————————————————————————————————————————————————————————————————————————————————
   ✖  @jupytergis/jupytergis-qgis:build
      src/plugins.ts(176,9): error TS2322: Type '() => JupyterGISDoc' is not assignable to type 'SharedDocumentFactory'.
        Type 'JupyterGISDoc' is not assignable to type 'YDocument<DocumentChange>'.
          Property 'onStateChanged' is protected but type 'YDocument<T>' is not a class derived from 'YDocument<T>'.
      
      

[nakul-py]

Now test build without lockfile passes after updating ydoc version but got other type mismatch error that fails the build.

[davidbrochart]

other type mismatch error

Which one?

[nakul-py]

Got this new error

———————————————————————————————————————————————————————————————————————————————————
   ✖  @jupytergis/jupytergis-qgis:build
      src/plugins.ts(176,9): error TS2322: Type '() => JupyterGISDoc' is not assignable to type 'SharedDocumentFactory'.
        Type 'JupyterGISDoc' is not assignable to type 'YDocument<DocumentChange>'.
          Property 'onStateChanged' is protected but type 'YDocument<T>' is not a class derived from 'YDocument<T>'.
      
      

This one

[nakul-py]

I think both JupyterGISDoc and SharedDocumentFactory similar, we are hitting just common typescript type mismatch error.

So i think to suppress it we have to give JupyterGISDoc() a type assertion?

[nakul-py]

Integration test failure are unrelated and 50 failed tests on every PR 😨

[martinRenou]

Integration test failure are unrelated and 50 failed tests on every PR 😨

This is due to using the new JupyterLab 4.6 in the CI with an outdated galata version in the ui-tests

[nakul-py]

This is due to using the new JupyterLab 4.6 in the CI with an outdated galata version in the ui-tests

Ohhh i see

[martinRenou]

Argh, we won't be able to have both lite and lab ui-tests running while jupyterlite 0.8.0 is not released.

[nakul-py]

Snapshots failure here. Why? 🤔

[nakul-py]

bot please update snapshots

[martinRenou]

Snapshots failure here. Why? 🤔

I think this is probably some UI change in JupyterLab. Good call on asking to update them 👍🏽

I'm surprised that the lite tests are passing, but 🤷🏽‍♂️

[nakul-py]

I'm surprised that the lite tests are passing

Yep sometimes lite tests automatic fails and pass

but the integration tests be like: Not today, You got work to do 😂.

[martinRenou]

Remaining failure is just the flaky stac result, seen before.

Thanks @nakul-py for this! Let's get it in