fix(overview): pin number grouping to en-US so output is locale-indep…#609
Open
NihalJain wants to merge 1 commit into
Open
fix(overview): pin number grouping to en-US so output is locale-indep…#609NihalJain wants to merge 1 commit into
NihalJain wants to merge 1 commit into
Conversation
…endent `codeburn overview` formatted token/call/session counts with a bare `toLocaleString()`, which groups digits according to the host's locale. On an Indian-locale machine (en-IN) a value like 2,002,000,000 renders as 2,00,20,00,000, so the rendered summary — and its snapshot test — differed by machine. (formatCost already avoided this via an explicit thousands regex.) Pin `formatTokens` to 'en-US' and route the remaining count columns through a new `formatCount` helper that does the same, so the overview output is byte-identical everywhere. Verify: `npm test -- overview` (previously failed on non-US locales; the "thousands separators" case now passes regardless of $LANG / ICU default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endent
codeburn overviewformatted token/call/session counts with a baretoLocaleString(), which groups digits according to the host's locale. On an Indian-locale machine (en-IN) a value like 2,002,000,000 renders as 2,00,20,00,000, so the rendered summary — and its snapshot test — differed by machine. (formatCost already avoided this via an explicit thousands regex.)Pin
formatTokensto 'en-US' and route the remaining count columns through a newformatCounthelper that does the same, so the overview output is byte-identical everywhere.Verify:
npm test -- overview(previously failed on non-US locales; the "thousands separators" case now passes regardless of $LANG / ICU default).Summary
Testing
npm testpassesnpm run buildsucceedsFor new providers only:
npm run dev -- todayshows correct costs and session counts for this providernpm run dev -- models --provider <name>shows correct model names and pricing