Conversation
The Help menu's "Launch Tutorial" opens the welcome level now, which is where a new player should start. File > Open... (⌘O) runs the same native directory picker as Settings > Level > Open..., with the same rules for what a pick means — the resolution moves to open_picked_dir so both entry points share it. Godot's global menu API can't attach a key equivalent, so the shortcut is a normal input action; the base action ships with no events and only the .macosx override binds ⌘O. Both the menu and the shortcut are macOS-only, and neither appears for a client joined to someone else's world, which can't open one of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two macOS menu-bar changes.
Help > Enu Welcome — was "Launch Tutorial" opening
tutorial-1; it opens the welcome level now, which is where a new player should start.File > Open... — a new File menu, before Help, running the same native directory picker as Settings > Level > Open... and following the same rules for what a picked directory means (a dir with a
level.jsonis a level: open its parent world at that level; anything else is a world, opened at its initial level). That resolution moved out ofSettings.show_open_worldintoopen_picked_dirso both entry points share one implementation.⌘O works as you'd expect from a File menu. Godot 3.5's global menu API builds every item with
keyEquivalent:@""and has no way to attach one, so the shortcut is a normal input action instead:open_worldships with no events and onlyopen_world.macosxbinds ⌘O, sois_action_pressedstays valid on every platform but can only fire here. Being modal on the main thread, the picker releases the pointer first — otherwise the mouse stays captured by a game the player can't see behind the dialog.Both are gated on
connect_address_override == "", the same test the welcome item already used: a client joined to someone else's world can't open one of its own.Testing
nim testpasses. Driven against a running Enu on macOS:Apple, Enu, File, Help; File containsOpen..., Help containsDocumentation, Web Site, ---, Enu Welcome.…/tutorial/welcomeloads that level.🤖 Generated with Claude Code