Repository navigation
Conversation
… 2.x, update Gradle to 9.8, and remove unused code and dependencies
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unbounded recommended IDE verification will continually expand and make CI increasingly resource-intensive.
Review effort: Balanced
Findings: None
What changed in this PR
Modernizes the IntelliJ theme plugin’s build, CI, compatibility baseline, and removes obsolete Kotlin template code.
Changes:
- Migrates to Gradle 9.8 and IntelliJ Platform Gradle Plugin 2.x.
- Updates CI to JDK 21 and current GitHub Actions.
- Removes unused services, listeners, localization, and lint configuration.
| File | Description |
|---|---|
.github/workflows/build.yml |
Modernizes build, verification, and release jobs. |
.gitignore |
Ignores IntelliJ Platform build data. |
CHANGELOG.md |
Documents modernization and removals. |
build.gradle.kts |
Migrates build and publishing configuration. |
detekt-config.yml |
Removes obsolete lint configuration. |
gradle.properties |
Updates versions and platform baseline. |
gradle/wrapper/gradle-wrapper.properties |
Upgrades the Gradle distribution. |
gradlew |
Updates the POSIX wrapper script. |
gradlew.bat |
Updates the Windows wrapper script. |
src/main/kotlin/com/github/getomni/jetbrains/MyBundle.kt |
Removes the unused message bundle helper. |
src/main/kotlin/com/github/getomni/jetbrains/listeners/MyProjectManagerListener.kt |
Removes the sample listener. |
src/main/kotlin/com/github/getomni/jetbrains/services/MyApplicationService.kt |
Removes the sample application service. |
src/main/kotlin/com/github/getomni/jetbrains/services/MyProjectService.kt |
Removes the sample project service. |
src/main/resources/META-INF/plugin.xml |
Removes obsolete service and listener registrations. |
src/main/resources/messages/MyBundle.properties |
Removes unused localized messages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… job Co-authored-by: mayconsgs <59394133+mayconsgs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request performs a major modernization and cleanup of the build system and project configuration for the IntelliJ theme plugin. The key changes include migrating to the latest IntelliJ Platform Gradle Plugin and Gradle versions, updating the CI workflow to use current tools and JDK 21, raising the minimum supported IDE version, and removing obsolete configuration and code. These updates improve maintainability, compatibility, and build reliability.
Build system and plugin configuration modernization:
gradle.propertiesandgradle-wrapper.propertiesaccordingly, and raised the minimum supported IDE version to 2024.2 (build 242) (gradle.properties,gradle/wrapper/gradle-wrapper.properties,CHANGELOG.md) [1] [2] [3].gradlew) to the latest, POSIX-compliant version with improved documentation and compatibility (gradlew) [1] [2].Continuous Integration (CI) improvements:
.github/workflows/build.ymlto use JDK 21, latest GitHub Actions, modern Gradle setup, and streamlined steps for build, verification, and release draft creation (.github/workflows/build.yml).Project cleanup:
detektandktlintconfiguration files, since the plugin no longer contains Kotlin code (CHANGELOG.md,detekt-config.yml) [1] [2].Documentation and metadata updates:
CHANGELOG.md).… 2.x, update Gradle to 9.8, and remove unused code and dependenciesChanges proposed
Additional context