Repository navigation
Build: Guard brotli-decompressor license review. - #356
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The pinned action ignores PURL versions, unintentionally exempting every brotli-decompressor version.
Review effort: Balanced
Findings: 1
What changed in this PR
Attempts to unblock dependency review for brotli-decompressor 6.0.1 while preserving existing license policy.
Changes:
- Adds a documented license-check exemption for
brotli-decompressor@6.0.1.
| File | Description |
|---|---|
.github/workflows/desktop-builds.yml |
Adds the dependency license exception. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The crate publishes BSD-3-Clause/MIT metadata while its shipped LICENSE contains BSD-3-Clause terms. Exclude the package from the GitHub action license parser and require a fresh review when Cargo.lock moves beyond the reviewed 5.0.3 and 6.0.1 versions. Vulnerability review remains enabled.
JJJ
force-pushed
the
jjj/brotli-license-review
branch
from
October 5, 2026 23:19
6aa38e5 to
ffc690b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
brotli-decompressorfrom GitHub dependency review's license parser. Version 6.0.1 publishes a slash-separatedBSD-3-Clause/MITexpression, while its packagedLICENSEfile contains BSD 3-Clause terms.Validation
cargo infoand its packagedLICENSEfile.npm run test:frontendon currentmain.git diff --check.