Skip to content

Build: Guard brotli-decompressor license review. - #356

Merged
JJJ merged 1 commit into
mainfrom
jjj/brotli-license-review
Oct 5, 2026
Merged

JJJ merged 1 commit into
mainfrom
jjj/brotli-license-review

Conversation

@JJJ

@JJJ JJJ commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Exclude brotli-decompressor from GitHub dependency review's license parser. Version 6.0.1 publishes a slash-separated BSD-3-Clause/MIT expression, while its packaged LICENSE file contains BSD 3-Clause terms.
  • The action ignores versions in exclusion purls. The required dependency policy audit now permits only the reviewed 5.0.3 and 6.0.1 lockfile versions, so another version requires fresh review. Vulnerability checks remain enabled.
  • This addresses the license check blocking Dependabot PR build(deps): bump the cargo-minor-and-patch group in /src-tauri with 8 updates #353.

Validation

  • Inspected the published 6.0.1 crate with cargo info and its packaged LICENSE file.
  • npm run test:frontend on current main.
  • Focused negative check: changing the locked version to 6.0.2 fails the dependency policy audit.
  • git diff --check.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 23:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The pinned action ignores PURL versions, unintentionally exempting every brotli-decompressor version.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Attempts to unblock dependency review for brotli-decompressor 6.0.1 while preserving existing license policy.

Changes:

  • Adds a documented license-check exemption for brotli-decompressor@6.0.1.
File Description
.github/​workflows/​desktop-builds.yml Adds the dependency license exception.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/desktop-builds.yml Outdated
The crate publishes BSD-3-Clause/MIT metadata while its shipped LICENSE contains BSD-3-Clause terms. Exclude the package from the GitHub action license parser and require a fresh review when Cargo.lock moves beyond the reviewed 5.0.3 and 6.0.1 versions. Vulnerability review remains enabled.
@JJJ
JJJ force-pushed the jjj/brotli-license-review branch from 6aa38e5 to ffc690b Compare October 5, 2026 23:19
@JJJ JJJ changed the title Build: Recognize brotli-decompressor license metadata. Build: Guard brotli-decompressor license review. Oct 5, 2026
@JJJ
JJJ merged commit 563a9bb into main Oct 5, 2026
18 checks passed
@JJJ
JJJ deleted the jjj/brotli-license-review branch October 5, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants