ref(typescript): Default to node16 module/moduleResolution

dev-packages/browser-integration-tests/tsconfig.json

@@ -3,7 +3,6 @@
 
   "compilerOptions": {
     "lib": ["dom", "ES2020"],
-    "moduleResolution": "node",
     "noEmit": true,
     "strict": true,
     "allowSyntheticDefaultImports": true,

dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
 // TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
 delete tsConfig.compilerOptions.noUncheckedIndexedAccess;
 
+// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
+// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
+// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
+// scenarios, which are loaded as CommonJS.
+delete tsConfig.compilerOptions.module;
+tsConfig.compilerOptions.moduleResolution = 'node';
+
 writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

dev-packages/node-integration-tests/scripts/use-ts-3_8.js

@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
 // TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
 delete tsConfig.compilerOptions.noUncheckedIndexedAccess;
 
+// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
+// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
+// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
+// scenarios, which are loaded as CommonJS.
+delete tsConfig.compilerOptions.module;
+tsConfig.compilerOptions.moduleResolution = 'node';
+
 writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

dev-packages/test-utils/tsconfig.json

@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "target": "ES2022",
-    "module": "ES2022",
     // package-specific options
     "esModuleInterop": true
   },

nx.json

@@ -5,7 +5,8 @@
       "{workspaceRoot}/*.js",
       "{workspaceRoot}/*.json",
       "{workspaceRoot}/yarn.lock",
-      "{workspaceRoot}/dev-packages/rollup-utils/**"
+      "{workspaceRoot}/dev-packages/rollup-utils/**",
+      "{workspaceRoot}/packages/typescript/**"
     ],
     "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
   },

packages/angular/tsconfig.json

@@ -1,12 +1,35 @@
 {
-  "extends": "../../tsconfig.json",
-
+  // NOTE: Unlike every other package, this config does NOT extend the shared base config
+  // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
+  // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
+  // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
+  // base compiler options here and use `esnext`/`node` instead.
   "include": ["**/*.ts", "src/**/*"],
 
   "exclude": ["patch-vitest.ts", "setup-test.ts"],
 
   "compilerOptions": {
-    // package-specific options
+    "declaration": false,
+    "declarationMap": false,
+    "downlevelIteration": true,
+    "importHelpers": true,
+    "inlineSources": true,
+    "isolatedModules": true,
+    "lib": ["es2020"],
+    "module": "esnext",
+    "moduleResolution": "node",
+    "noErrorTruncation": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "preserveWatchOutput": true,
+    "sourceMap": true,
+    "strict": true,
+    "strictBindCallApply": false,
+    "target": "es2020",
+    "noUncheckedIndexedAccess": true,
+    "skipLibCheck": true,
     "experimentalDecorators": true
   }
 }

packages/astro/tsconfig.json

@@ -4,6 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
+    "module": "esnext",
     "moduleResolution": "bundler"
     // package-specific options
   }

packages/browser/tsconfig.json

@@ -4,6 +4,7 @@
   "include": ["src/**/*", "test/loader.js"],
 
   "compilerOptions": {
+    "module": "esnext",
     "moduleResolution": "bundler",
     "lib": ["DOM", "es2020", "WebWorker"]
   }

packages/cloudflare/tsconfig.json

@@ -5,6 +5,7 @@
 
   "compilerOptions": {
     "module": "esnext",
+    "moduleResolution": "bundler",
     "types": ["node", "@cloudflare/workers-types"]
   }
 }

packages/deno/tsconfig.json

@@ -4,6 +4,7 @@
   "compilerOptions": {
     "lib": ["esnext"],
     "module": "esnext",
+    "moduleResolution": "bundler",
     "target": "esnext"
   }
 }

packages/feedback/tsconfig.json

@@ -2,6 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "module": "esnext",
+    "moduleResolution": "bundler",
 
     /* Preact Config */
     "jsx": "react-jsx",

packages/hono/tsconfig.json

@@ -5,6 +5,7 @@
 
   "compilerOptions": {
     "module": "esnext",
+    "moduleResolution": "bundler",
     "types": ["node", "@cloudflare/workers-types"]
   }
 }

packages/integration-shims/tsconfig.json

@@ -4,6 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
+    "module": "esnext",
     "moduleResolution": "bundler"
     // package-specific options
   }

packages/node-core/tsconfig.json

@@ -4,8 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["ES2020", "ES2021.WeakRef"],
-    "module": "Node16",
-    "moduleResolution": "Node16"
+    "lib": ["ES2020", "ES2021.WeakRef"]
   }
 }

packages/node-native/tsconfig.json

@@ -2,7 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "module": "esnext",
-    "lib": ["es2020"],
+    "moduleResolution": "bundler",
     "outDir": "build",
     "types": ["node"]
   },

packages/node/tsconfig.json

@@ -1,11 +1,5 @@
 {
   "extends": "../../tsconfig.json",
 
-  "include": ["src/**/*"],
-
-  "compilerOptions": {
-    "lib": ["es2020"],
-    "module": "Node16",
-    "moduleResolution": "Node16"
-  }
+  "include": ["src/**/*"]
 }

packages/profiling-node/tsconfig.json

@@ -2,7 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "module": "esnext",
-    "lib": ["es2020"],
+    "moduleResolution": "bundler",
     "outDir": "build",
     "types": ["node"]
   },

packages/react-router/test/server/wrapServerAction.test.ts

@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
   it('should skip span creation and warn when instrumentation API is used', async () => {
     // Reset modules to get a fresh copy with unset warning flag
     vi.resetModules();
-    // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
     const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');
 
     // Set the global flag indicating instrumentation API is in use

packages/react-router/test/server/wrapServerLoader.test.ts

@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
   it('should skip span creation and warn when instrumentation API is used', async () => {
     // Reset modules to get a fresh copy with unset warning flag
     vi.resetModules();
-    // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
     const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');
 
     // Set the global flag indicating instrumentation API is in use

packages/react-router/tsconfig.json

@@ -4,6 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
+    "module": "esnext",
     "moduleResolution": "bundler",
     "jsx": "react"
   }

packages/replay-canvas/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "lib": ["DOM", "es2020"],
-    "module": "esnext"
+    "module": "esnext",
+    "moduleResolution": "bundler"
   },
   "include": ["src/**/*.ts"]
 }

packages/replay-internal/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "lib": ["DOM", "es2020"],
-    "module": "esnext"
+    "module": "esnext",
+    "moduleResolution": "bundler"
   },
   "include": ["src/**/*.ts"]
 }

packages/replay-worker/tsconfig.json

@@ -2,6 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "module": "esnext",
+    "moduleResolution": "bundler",
     "lib": ["webworker", "scripthost"],
     "esModuleInterop": true,
     "target": "es2020",

packages/server-utils/tsconfig.json

@@ -1,9 +1,5 @@
 {
   "extends": "../../tsconfig.json",
 
-  "include": ["src/**/*"],
-
-  "compilerOptions": {
-    "lib": ["ES2020"]
-  }
+  "include": ["src/**/*"]
 }

packages/solid/tsconfig.json

@@ -4,6 +4,11 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["DOM", "es2020"]
+    "lib": ["DOM", "es2020"],
+    // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
+    // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
+    // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
+    "module": "esnext",
+    "moduleResolution": "bundler"
   }
 }

packages/svelte/tsconfig.json

@@ -4,6 +4,11 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    "lib": ["DOM", "es2020"]
+    "lib": ["DOM", "es2020"],
+    // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
+    // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
+    // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
+    "module": "esnext",
+    "moduleResolution": "node"
   }
 }

packages/tanstackstart/tsconfig.json

@@ -1,9 +1,4 @@
 {
   "extends": "../../tsconfig.json",
-  "include": ["src/**/*"],
-  "compilerOptions": {
-    "lib": ["es2020"],
-    "module": "Node16",
-    "moduleResolution": "Node16"
-  }
+  "include": ["src/**/*"]
 }

packages/types/tsconfig.json

@@ -1,9 +1,5 @@
 {
   "extends": "../../tsconfig.json",
 
-  "include": ["src/**/*"],
-
-  "compilerOptions": {
-    "lib": ["es2020"]
-  }
+  "include": ["src/**/*"]
 }

packages/typescript/tsconfig.json

@@ -7,7 +7,8 @@
     "inlineSources": true,
     "isolatedModules": true,
     "lib": ["es2020"],
-    "moduleResolution": "node",
+    "module": "node16",
+    "moduleResolution": "node16",
     "noErrorTruncation": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitReturns": true,