ref(node): Migrate vendored generic-pool instrumentation to Sentry APIs#21523
Merged
Conversation
nicohrubec
changed the title
Replace the OTel tracer/context span lifecycle in the vendored generic-pool instrumentation with `startSpan`/`startSpanManual` from `@sentry/core`, and set an error status on failed acquires. Adds error-path integration tests for both the v3 (promise) and v2 (callback) paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
feat/generic-pool-vendored-sentry-apis
branch
from
8aa80ed to
2146bfa
Compare
nicohrubec
commented
Jun 15, 2026
| original.call( | ||
| this, | ||
| (err: unknown, client: unknown) => { | ||
| if (err) { |
Member
Author
There was a problem hiding this comment.
this aligns the v2 and v3 error path (so both set internal error on the span)
Contributor
size-limit report 📦
|
nicohrubec
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
andreiborza
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the vendored generic-pool instrumentation off the OTel tracer/context APIs to
startSpan/startSpanManualfrom@sentry/core.