ref(integrations): route HTTP header filtering through data collection config - #6788
Merged
@sentry/warden / warden: code-review
completed
Jul 9, 2026 in 0s
1 issue
code-review: Found 1 issue (1 low)
Low
Test branches on parametrize ID string instead of `expected is None`, risking silent test failure - `tests/integrations/aiohttp/test_aiohttp.py:1409`
In test_sensitive_header_passthrough_with_pii_span_streaming, use if expected is None instead of if request.node.callspec.id == "data_collection_off_does_not_add_headers". If the parametrize ID is ever renamed, the intended branch is silently skipped and the else branch runs expected["authorization"] on None, raising a TypeError. Keying on the semantically-meaningful expected value is more robust.
⏱ 10m 58s · 1.4M in / 63.5k out · $2.13
Loading