feat(integrations): Gate user info behind data_collection config - #6876
2 issues
code-review: Found 2 issues (2 medium)
Medium
AWS Lambda body handling skipped when data_collection is enabled - `sentry_sdk/integrations/aws_lambda.py:441-456`
When has_data_collection_enabled is true, the elif should_send_default_pii() branch is skipped, so request body is neither collected nor redacted.
AWS Lambda user-info tests use non-standard event structure - `tests/integrations/aws_lambda/test_aws_lambda.py:430-432`
The test payload changed from standard requestContext.identity to a top-level identity field that doesn't match real AWS API Gateway events, causing tests to verify behavior with a fictional event structure instead of production reality.
⏱ 15m 17s · 3.9M in / 128.4k out · $1.35
Annotations
Check warning on line 456 in sentry_sdk/integrations/aws_lambda.py
sentry-warden / warden: code-review
AWS Lambda body handling skipped when data_collection is enabled
When `has_data_collection_enabled` is true, the `elif should_send_default_pii()` branch is skipped, so request body is neither collected nor redacted.
Check warning on line 432 in tests/integrations/aws_lambda/test_aws_lambda.py
sentry-warden / warden: code-review
AWS Lambda user-info tests use non-standard event structure
The test payload changed from standard `requestContext.identity` to a top-level `identity` field that doesn't match real AWS API Gateway events, causing tests to verify behavior with a fictional event structure instead of production reality.