Skip to content

feat(data-collection): Port Rails log subscriber - #3034

Open
sl0thentr0py wants to merge 1 commit into
neel/data-collection/railsfrom
neel/data-collection/rails-logs
Open

feat(data-collection): Port Rails log subscriber #3034
sl0thentr0py wants to merge 1 commit into
neel/data-collection/railsfrom
neel/data-collection/rails-logs

feat(data-collection): Port Rails log subscribers

6b771d6
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: security-review completed Jul 23, 2026 in 0s

1 issue

security-review: Found 1 issue (1 medium)

Medium

Removing ParameterFilter leaves nested sensitive params unscrubbed in Sentry logs - `sentry-rails/spec/sentry/rails/log_subscribers/active_job_subscriber_spec.rb:365-366`

With ParameterFilter removed, only top-level param/argument keys are filtered; nested values like { user: { password: "..." } } are sent to Sentry structured logs raw because the new filter never recurses into hash values.

Also found at:

  • sentry-rails/lib/sentry/rails/log_subscribers/action_mailer_subscriber.rb:73-75

⏱ 1m 38s · 1.0M in / 61.2k out · $0.70

Annotations

Check warning on line 366 in sentry-rails/spec/sentry/rails/log_subscribers/active_job_subscriber_spec.rb

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: security-review

Removing ParameterFilter leaves nested sensitive params unscrubbed in Sentry logs

With `ParameterFilter` removed, only top-level param/argument keys are filtered; nested values like `{ user: { password: "..." } }` are sent to Sentry structured logs raw because the new filter never recurses into hash values.

Check warning on line 75 in sentry-rails/lib/sentry/rails/log_subscribers/action_mailer_subscriber.rb

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: security-review

[LJX-Z2J] Removing ParameterFilter leaves nested sensitive params unscrubbed in Sentry logs (additional location)

With `ParameterFilter` removed, only top-level param/argument keys are filtered; nested values like `{ user: { password: "..." } }` are sent to Sentry structured logs raw because the new filter never recurses into hash values.