Skip to content

Fix Social Auth Sign-Up Validation Failures #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yash-pouranik merged 5 commits into from
Jul 17, 2026
+288 −27
Merged

Fix Social Auth Sign-Up Validation Failures #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6323c5
Fix Social Auth Sign-Up Validation Failures
AYUSH-P-SINGH Jul 11, 2026
61a8f87
Improve error handling for social signup
AYUSH-P-SINGH Jul 15, 2026
fa439a6
Update apps/public-api/src/controllers/userAuth.controller.js
yash-pouranik Jul 15, 2026
ae65fa4
Refactor error handling in userAuth.controller
AYUSH-P-SINGH Jul 15, 2026
80b413b
Add AppError class and improve social auth tests
AYUSH-P-SINGH Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
256 changes: 256 additions & 0 deletions apps/public-api/src/__tests__/userAuth.social.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@ jest.mock('@urbackend/common', () => {
if (encrypted.encrypted === 'google') return 'google_secret';
return null;
}),
AppError: class AppError extends Error {
constructor(statusCode, message, error = null) {
super(message);
this.statusCode = statusCode;
this.status = `${statusCode}`.startsWith('4') ? 'fail' : 'error';
this.error = error || (statusCode >= 500 ? "Internal Server Error" : "Error");
this.isOperational = true;
}
},
};
});

Expand Down Expand Up @@ -690,4 +699,251 @@ describe('public userAuth social auth', () => {
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('error='));
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('deletion'));
});

test('handleSocialAuthCallback handles ValidationError on create by saving with validateBeforeSave: false', async () => {
redis.get.mockResolvedValueOnce(JSON.stringify({
projectId: 'project_1',
provider: 'github',
callbackUrl: 'http://localhost:5173/auth/callback',
}));
mockProjectFindByIdChain.lean.mockResolvedValueOnce(makeProject());

mockUsersModel.findOne
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);

const mockSave = jest.fn().mockResolvedValue(undefined);
class MockModel {
constructor(payload) {
Object.assign(this, payload);
this._id = 'mocked_user_id';
}
}
MockModel.prototype.save = mockSave;
MockModel.findOne = jest.fn()
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);
MockModel.create = jest.fn().mockImplementation(() => {
const error = new Error('users validation failed: customField: Path `customField` is required.');
error.name = 'ValidationError';
throw error;
});

const { getCompiledModel } = require('@urbackend/common');
getCompiledModel.mockReturnValueOnce(MockModel);

global.fetch
.mockResolvedValueOnce({
ok: true,
json: async () => ({ access_token: 'github_access_token' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ({ id: 123, login: 'alice', avatar_url: '' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ([{ email: 'alice@example.com', verified: true, primary: true }]),
});

const req = makeReq({ params: { provider: 'github' }, query: { code: 'code_1', state: 'state_1' } });
const res = makeRes();

await controller.handleSocialAuthCallback(req, res);

expect(MockModel.create).toHaveBeenCalled();
expect(mockSave).toHaveBeenCalledWith({ validateBeforeSave: false });
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('/auth/callback?'));
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('userId=mocked_user_id'));
});

test('handleSocialAuthCallback handles ValidationError on create where save fails with 11000 duplicate key error', async () => {
redis.get.mockResolvedValueOnce(JSON.stringify({
projectId: 'project_1',
provider: 'github',
callbackUrl: 'http://localhost:5173/auth/callback',
}));
mockProjectFindByIdChain.lean.mockResolvedValueOnce(makeProject());

mockUsersModel.findOne
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);

const mockSave = jest.fn().mockRejectedValue({ code: 11000 });
class MockModel {
constructor(payload) {
Object.assign(this, payload);
}
}
MockModel.prototype.save = mockSave;
MockModel.findOne = jest.fn()
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);
MockModel.create = jest.fn().mockImplementation(() => {
const error = new Error('users validation failed: customField: Path `customField` is required.');
error.name = 'ValidationError';
throw error;
});

const { getCompiledModel } = require('@urbackend/common');
getCompiledModel.mockReturnValueOnce(MockModel);

global.fetch
.mockResolvedValueOnce({
ok: true,
json: async () => ({ access_token: 'github_access_token' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ({ id: 123, login: 'alice', avatar_url: '' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ([{ email: 'alice@example.com', verified: true, primary: true }]),
});

const req = makeReq({ params: { provider: 'github' }, query: { code: 'code_1', state: 'state_1' } });
const res = makeRes();

await controller.handleSocialAuthCallback(req, res);

expect(MockModel.create).toHaveBeenCalled();
expect(mockSave).toHaveBeenCalledWith({ validateBeforeSave: false });
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('error=User+already+exists.'));
});

test('handleSocialAuthCallback handles ValidationError on create where save fails with generic database error', async () => {
redis.get.mockResolvedValueOnce(JSON.stringify({
projectId: 'project_1',
provider: 'github',
callbackUrl: 'http://localhost:5173/auth/callback',
}));
mockProjectFindByIdChain.lean.mockResolvedValueOnce(makeProject());

mockUsersModel.findOne
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);

const mockSave = jest.fn().mockRejectedValue(new Error('Connection timed out'));
class MockModel {
constructor(payload) {
Object.assign(this, payload);
}
}
MockModel.prototype.save = mockSave;
MockModel.findOne = jest.fn()
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);
MockModel.create = jest.fn().mockImplementation(() => {
const error = new Error('users validation failed: customField: Path `customField` is required.');
error.name = 'ValidationError';
throw error;
});

const { getCompiledModel } = require('@urbackend/common');
getCompiledModel.mockReturnValueOnce(MockModel);

global.fetch
.mockResolvedValueOnce({
ok: true,
json: async () => ({ access_token: 'github_access_token' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ({ id: 123, login: 'alice', avatar_url: '' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ([{ email: 'alice@example.com', verified: true, primary: true }]),
});

const req = makeReq({ params: { provider: 'github' }, query: { code: 'code_1', state: 'state_1' } });
const res = makeRes();

await controller.handleSocialAuthCallback(req, res);

expect(MockModel.create).toHaveBeenCalled();
expect(mockSave).toHaveBeenCalledWith({ validateBeforeSave: false });
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('error=Failed+to+complete+social+signup.'));
});

test('handleSocialAuthCallback handles direct duplicate key error on Model.create', async () => {
redis.get.mockResolvedValueOnce(JSON.stringify({
projectId: 'project_1',
provider: 'github',
callbackUrl: 'http://localhost:5173/auth/callback',
}));
mockProjectFindByIdChain.lean.mockResolvedValueOnce(makeProject());

mockUsersModel.findOne
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);

mockUsersModel.create.mockImplementationOnce(() => {
const error = new Error('E11000 duplicate key error collection');
error.code = 11000;
throw error;
});

global.fetch
.mockResolvedValueOnce({
ok: true,
json: async () => ({ access_token: 'github_access_token' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ({ id: 123, login: 'alice', avatar_url: '' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ([{ email: 'alice@example.com', verified: true, primary: true }]),
});

const req = makeReq({ params: { provider: 'github' }, query: { code: 'code_1', state: 'state_1' } });
const res = makeRes();

await controller.handleSocialAuthCallback(req, res);

expect(mockUsersModel.create).toHaveBeenCalled();
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('error=User+already+exists.'));
});

test('handleSocialAuthCallback handles direct generic database error on Model.create', async () => {
redis.get.mockResolvedValueOnce(JSON.stringify({
projectId: 'project_1',
provider: 'github',
callbackUrl: 'http://localhost:5173/auth/callback',
}));
mockProjectFindByIdChain.lean.mockResolvedValueOnce(makeProject());

mockUsersModel.findOne
.mockResolvedValueOnce(null)
.mockResolvedValueOnce(null);

mockUsersModel.create.mockImplementationOnce(() => {
throw new Error('Database connection lost');
});

global.fetch
.mockResolvedValueOnce({
ok: true,
json: async () => ({ access_token: 'github_access_token' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ({ id: 123, login: 'alice', avatar_url: '' }),
})
.mockResolvedValueOnce({
ok: true,
json: async () => ([{ email: 'alice@example.com', verified: true, primary: true }]),
});

const req = makeReq({ params: { provider: 'github' }, query: { code: 'code_1', state: 'state_1' } });
const res = makeRes();

await controller.handleSocialAuthCallback(req, res);

expect(mockUsersModel.create).toHaveBeenCalled();
expect(res.redirect).toHaveBeenCalledWith(expect.stringContaining('error=Failed+to+complete+social+signup.'));
});
});
33 changes: 32 additions & 1 deletion apps/public-api/src/controllers/userAuth.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,31 @@ const findOrCreateSocialUser = async ({ project, usersColConfig, Model, provider
newUserPayload.avatarUrl = profile.avatarUrl;
}

user = await Model.create(newUserPayload);
try {
user = await Model.create(newUserPayload);
} catch (err) {
if (err.name === "ValidationError") {
try {
if (typeof Model === "function") {
const doc = new Model(newUserPayload);
await doc.save({ validateBeforeSave: false });
user = doc;
} else {
user = await Model.create(newUserPayload);
}
} catch (saveErr) {
if (saveErr.code === 11000) {
throw new AppError(409, "User already exists.");
}
throw new AppError(500, "Failed to complete social signup.");
}
} else {
if (err.code === 11000) {
throw new AppError(409, "User already exists.");
}
throw new AppError(500, "Failed to complete social signup.");
}
Comment thread
yash-pouranik marked this conversation as resolved.
}
return { user, isNewUser: true, linkedByEmail: false };
};

Expand Down Expand Up @@ -1836,3 +1860,10 @@ module.exports.updateAdminUser = async (req, res) => {
res.status(500).json({ error: err.message });
}
};







Loading
Loading