Skip to content

fix: date filter parameters collide across OR clauses #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
totto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: date filter parameters collide across OR clauses #1596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions graphiti_core/search/search_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,11 @@ def edge_search_filter_query_constructor(
ComparisonOperator.is_null,
ComparisonOperator.is_not_null,
]:
filter_params['valid_at_' + str(j)] = date_filter.date
filter_params[f'valid_at_{i}_{j}'] = date_filter.date

and_filters = [
date_filter_query_constructor(
'e.valid_at', f'$valid_at_{j}', date_filter.comparison_operator
'e.valid_at', f'$valid_at_{i}_{j}', date_filter.comparison_operator
)
for j, date_filter in enumerate(or_list)
]
Expand All @@ -185,11 +185,11 @@ def edge_search_filter_query_constructor(
ComparisonOperator.is_null,
ComparisonOperator.is_not_null,
]:
filter_params['invalid_at_' + str(j)] = date_filter.date
filter_params[f'invalid_at_{i}_{j}'] = date_filter.date

and_filters = [
date_filter_query_constructor(
'e.invalid_at', f'$invalid_at_{j}', date_filter.comparison_operator
'e.invalid_at', f'$invalid_at_{i}_{j}', date_filter.comparison_operator
)
for j, date_filter in enumerate(or_list)
]
Expand All @@ -216,11 +216,11 @@ def edge_search_filter_query_constructor(
ComparisonOperator.is_null,
ComparisonOperator.is_not_null,
]:
filter_params['created_at_' + str(j)] = date_filter.date
filter_params[f'created_at_{i}_{j}'] = date_filter.date

and_filters = [
date_filter_query_constructor(
'e.created_at', f'$created_at_{j}', date_filter.comparison_operator
'e.created_at', f'$created_at_{i}_{j}', date_filter.comparison_operator
)
for j, date_filter in enumerate(or_list)
]
Expand All @@ -247,11 +247,11 @@ def edge_search_filter_query_constructor(
ComparisonOperator.is_null,
ComparisonOperator.is_not_null,
]:
filter_params['expired_at_' + str(j)] = date_filter.date
filter_params[f'expired_at_{i}_{j}'] = date_filter.date

and_filters = [
date_filter_query_constructor(
'e.expired_at', f'$expired_at_{j}', date_filter.comparison_operator
'e.expired_at', f'$expired_at_{i}_{j}', date_filter.comparison_operator
)
for j, date_filter in enumerate(or_list)
]
Expand Down
Loading