fix: keep includeSubdomains when STSPreload is enabled - #74
Open
c879873067877881111 wants to merge 1 commit into
Open
Conversation
STSPreload overwrote stsSub instead of appending, so enabling both STSIncludeSubdomains and STSPreload dropped the includeSubdomains directive from the Strict-Transport-Security header. Append the preload directive instead so both are emitted. Refs gin-contrib#52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
STSIncludeSubdomainsandSTSPreloadare set, theStrict-Transport-Securityheader dropsincludeSubdomainsand only sends:The preload branch in
policy.gowas overwritingstsSubinstead ofappending to it:
Changed it to
+=so both directives are kept:Added a test for the both-enabled case.
Note: #52 also asks whether
STSPreloadshould be enabled by default inDefaultConfig(). I left that out here since it changes default behaviour —happy to do a follow-up if you'd like.
Refs #52