Open
Conversation
Not all registry implementations support `HEAD` correctly.
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the private registry reachability checks used by the start-proxy action, aiming to make the connectivity tests more compatible across different registry implementations and provide clearer logging.
Changes:
- Switch the reachability probe request from
HEADtoGETwhile still not reading the body (res.destroy()immediately). - Add registry-type-specific test URL handling (NuGet: test service index).
- Add a doc link disclaimer and group logging around connection tests.
Show a summary per file
| File | Description |
|---|---|
src/start-proxy/reachability.ts |
Updates request method to GET, adds NuGet-specific test URL logic, and improves logging (group + disclaimer). |
src/start-proxy-action.ts |
Clarifies comment that registry checks are best-effort. |
src/doc-url.ts |
Adds a documentation URL for private registry diagnostic logs. |
lib/start-proxy-action.js |
Generated JS output corresponding to TS changes (not reviewed). |
Copilot's findings
- Files reviewed: 3/4 changed files
- Comments generated: 2
227a268 to
7a818e6
Compare
| const checkConnection = sinon.stub(backend, "checkConnection").resolves(200); | ||
|
|
||
| const messages = await withRecordingLoggerAsync(async (logger) => { | ||
| const reachable = await checkConnections( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor improvements to the private registry connection checks:
GETinstead ofHEADrequests, for better compatibility. Some registries don't likeHEADrequests. We still callres.destroy()immediately after inspecting the status code, so never read the response body. So usingGEToverHEADshould have a minimal impact on performance.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist