-
Notifications
You must be signed in to change notification settings - Fork 453
Bump the npm-minor group across 1 directory with 5 updates #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -386,7 +386,7 @@ class OfflineFeatures implements FeatureEnablement { | |
| getFeatureConfig(feature: Feature): FeatureConfig { | ||
| // Narrow the type to FeatureConfig to avoid type errors. To avoid unsafe use of `as`, we | ||
| // check that the required properties exist using `satisfies`. | ||
|
Comment on lines
387
to
388
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this comment be changed now? |
||
| return featureConfig[feature] satisfies FeatureConfig as FeatureConfig; | ||
| return featureConfig[feature] satisfies FeatureConfig; | ||
| } | ||
|
|
||
| /** | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -601,7 +601,7 @@ async function testFailedSarifUpload( | |
| uploadFiles.resolves({ | ||
| sarifID: "42", | ||
| statusReport: { raw_upload_size_bytes: 20, zipped_upload_size_bytes: 10 }, | ||
| } as uploadLib.UploadResult); | ||
| }); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This correctly checks the type without |
||
| const waitForProcessing = sinon.stub(uploadLib, "waitForProcessing"); | ||
|
|
||
| const features = [] as Feature[]; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -422,7 +422,7 @@ async function testLanguageAliases( | |
| ], | ||
| }, | ||
| }, | ||
| } as Workflow, | ||
| }, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also fine. |
||
| codeql, | ||
| ); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the intention with these type casts was to ensure that the objects satisfy the
UserConfiginterface and so should have been e.g.satisfies UserConfig. It's probably better for us to fix this (by changingastosatisfies) rather than removing this entirely.