Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/config-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ export async function getLanguages(
return languages;
}

/** Parses the `languages` input into a list of languages without checking if they are supported by CodeQL. */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Really all this does is split a comma-separated string into an array, removes excess space characters, converts the strings to lower-case, and removes empty elements. The current description might suggest that something more specific to languages is happening here. How about:

Splits a comma-separated string into an array. Excess spaces are removed and all characters are converted to lower-case.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a little implementation specific. Perhaps the main opposition is with "Parses"? I'll update that.

export function getRawLanguagesNoAutodetect(
languagesInput: string | undefined,
): string[] {
Expand Down