feat(expander): add ExpandParameterWithOptions and ExpandResponseWithOptions#292
Merged
fredbi merged 1 commit intoJul 20, 2026
Conversation
…Options ExpandParameter/ExpandParameterWithRoot and ExpandResponse/ExpandResponseWithRoot expand a parameter or response but take no ExpandOptions, so they always use the package default (unsandboxed) document loader — the same gap that motivated ExpandSchemaWithOptions. go-openapi/validate expands every parameter and response $ref of a spec through these functions, so a $ref from an untrusted source could not be confined there. Add ExpandParameterWithOptions(parameter, root, cache, opts) and ExpandResponseWithOptions(response, root, cache, opts): the option-aware forms. When root is non-nil, refs resolve against the in-memory root (base derived from root); otherwise they resolve relative to opts.RelativeBase. In particular opts.PathLoaderWithOptions / PathLoader inject a confined loader. The four existing functions are reimplemented in terms of the new ones, so their behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 68.49% 68.43% -0.07%
==========================================
Files 30 30
Lines 2438 2433 -5
==========================================
- Hits 1670 1665 -5
Misses 599 599
Partials 169 169 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpandParameter/ExpandParameterWithRoot and ExpandResponse/ExpandResponseWithRoot expand a parameter or response but take no ExpandOptions, so they always use the package default (unsandboxed) document loader — the same gap that motivated ExpandSchemaWithOptions. go-openapi/validate expands every parameter and response $ref of a spec through these functions, so a $ref from an untrusted source could not be confined there.
Add ExpandParameterWithOptions(parameter, root, cache, opts) and ExpandResponseWithOptions(response, root, cache, opts): the option-aware forms. When root is non-nil, refs resolve against the in-memory root (base derived from root); otherwise they resolve relative to opts.RelativeBase. In particular opts.PathLoaderWithOptions / PathLoader inject a confined loader. The four existing functions are reimplemented in terms of the new ones, so their behavior is unchanged.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist