web: centralize file picker custom values#23169
Open
dominic-r wants to merge 1 commit into
Open
Conversation
Agent-thread: https://sdko.org/internal/thr/ak/019ed837-6a7a-7492-bc76-93d55a130a27 A7k-product: product A7k-product-repo: 1 Co-authored-by: Agent <gptagent@svc.sdko.net>
dominic-r
added
the
area:frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23169 +/- ##
==========================================
+ Coverage 93.18% 93.28% +0.09%
==========================================
Files 1032 1035 +3
Lines 60196 60314 +118
Branches 400 400
==========================================
+ Hits 56094 56263 +169
+ Misses 4102 4051 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-600619721bd35e4a40499d8c22e3dfa51c374cdc
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-600619721bd35e4a40499d8c22e3dfa51c374cdcAfterwards, run the upgrade commands from the latest release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createObjecthook toak-search-selectso generic creatable behavior no longer assumes custom objects look like{ name: value }.ak-file-search-input.adminFileListcalls.Why
The file picker needs to support custom values like external URLs and Font Awesome icons, but that object shape belongs to the file picker, not the generic search-select. Consolidating that behavior keeps all file-picker surfaces consistent and reduces duplicate media-list requests.
Validation
make webNotes:
make webcompleted successfully. lit-analyse still reports existing warnings in unrelated drawer/captcha files.