Port tutorial analyses to SimplifiedSpec and reuse SimplifiedUnitAnalysis defaults while preserving unitAnalysis compatibility

[Copilot]

This PR ports tutorial analyses to the SimplifiedSpec interface while preserving compatibility for analyses that depend on UnitAnalysis.Spec.

In addition, based on review feedback, it introduces reusable default transfer-function behavior in SimplifiedUnitAnalysis and applies it where feasible to reduce boilerplate in tutorial analyses.

What changed

• Kept unitAnalysis.ml in its original MCPSpec-compatible form.
• Added a separate simplified tutorial analysis (simplifiedUnitAnalysis.ml) and exported it from src/goblint_lib.ml.
• Introduced SimplifiedUnitAnalysis.DefaultSpec for shared no-op/default simplified transfer functions.
• Updated tutorial signs analyses to include SimplifiedUnitAnalysis.DefaultSpec where feasible:
  • src/analyses/tutorials/signs.ml
  • src/analyses/tutorials/solution/signsSol.ml
  • src/analyses/tutorials/solution/signsExtendSol.ml
• Kept analysis-specific behavior explicit where semantics differ (e.g., context, threadenter).

Validation

• Attempted make native in this environment (blocked by missing opam/dune).
• Ran final parallel validation:
  • Code Review: no remaining findings.
  • CodeQL: no analyzable-language findings for these changes.

[michael-schwarz]

@copilot: Modules missing from src/goblint_lib.ml: {'SimplifiedUnitAnalysis'}

[Copilot]

@copilot: Modules missing from src/goblint_lib.ml: {'SimplifiedUnitAnalysis'}

Fixed in 812244e by adding module SimplifiedUnitAnalysis = SimplifiedUnitAnalysis to /home/runner/work/analyzer/analyzer/src/goblint_lib.ml.

[michael-schwarz]

The SimplifiedUnitAnalysis should be used to reduce boilerplate in the other analyses.

[Copilot]

@copilot: Modules missing from src/goblint_lib.ml: {'SimplifiedUnitAnalysis'}

This is already addressed in commit 812244e: module SimplifiedUnitAnalysis = SimplifiedUnitAnalysis is exported from /home/runner/work/analyzer/analyzer/src/goblint_lib.ml.

[michael-schwarz]

@copilot: The tutorial analysis should, where feasible, not define everything from scratch but build on the SimplifiedUnitAnalysis.

[Copilot]

@copilot: The tutorial analysis should, where feasible, not define everything from scratch but build on the SimplifiedUnitAnalysis.

Implemented in 2afea51 (with main refactor in 7aa7b6a): tutorial signs analyses now reuse shared no-op/default transfer functions via SimplifiedUnitAnalysis.DefaultSpec where feasible, while keeping analysis-specific context/threadenter explicit.

[Copilot]

Pull request overview

Ports multiple tutorial analyses from Analyses.MCPSpec to the SimplifiedAnalysis.SimplifiedSpec interface, adds a reusable SimplifiedUnitAnalysis.DefaultSpec to reduce boilerplate, and registers the simplified analyses via MCPRegistry.registered_simplified_analysis while keeping UnitAnalysis compatibility intact.

Changes:

• Export SimplifiedUnitAnalysis from goblint_lib and add a new tutorial simplifiedUnit analysis plus a reusable DefaultSpec.
• Port tutorial analyses (constants, signs, taint and solutions) to SimplifiedSpec and update their registrations.
• Reuse SimplifiedUnitAnalysis.DefaultSpec in the signs tutorial analyses to reduce duplicated no-op transfer functions.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/goblint_lib.ml	Exposes SimplifiedUnitAnalysis from the library interface.
src/analyses/tutorials/simplifiedUnitAnalysis.ml	Adds DefaultSpec and a minimal simplifiedUnit simplified analysis.
src/analyses/tutorials/signs.ml	Ports tutorial signs analysis to SimplifiedSpec and reuses DefaultSpec.
src/analyses/tutorials/solution/signsSol.ml	Ports solution signs analysis to SimplifiedSpec and reuses DefaultSpec.
src/analyses/tutorials/solution/signsExtendSol.ml	Ports extended solution signs analysis to SimplifiedSpec and reuses DefaultSpec.
src/analyses/tutorials/constants.ml	Ports constants tutorial analysis to SimplifiedSpec.
src/analyses/tutorials/taint.ml	Ports taint tutorial analysis skeleton to SimplifiedSpec.
src/analyses/tutorials/solution/taintSol.ml	Ports taint solution analysis to SimplifiedSpec.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[michael-schwarz]

Should be squashed once the time to merge comes.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.