openpgp/packet: limit embedded signature recursion depth#356
Open
BiswajeetRay7 wants to merge 1 commit into
Open
openpgp/packet: limit embedded signature recursion depth#356BiswajeetRay7 wants to merge 1 commit into
BiswajeetRay7 wants to merge 1 commit into
Conversation
Without a depth limit on embedded signature subpacket parsing, a malicious OpenPGP packet with deeply nested embeddedSignatureSubpacket fields causes infinite recursion in parse(), leading to a stack overflow. Add maxEmbeddedSignatureDepth=2 and pass a depth parameter through parseWithDepth, parseSignatureSubpackets, and parseSignatureSubpacket to prevent unbounded recursion. Fixes golang/go#79923
Contributor
|
This PR (HEAD: 59fc5d5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/788865. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a depth limit on embedded signature subpacket parsing,
a malicious OpenPGP packet with deeply nested
embeddedSignatureSubpacket fields causes infinite recursion in
parse(), leading to a stack overflow crash.
Add maxEmbeddedSignatureDepth=2 and pass a depth parameter through
parseWithDepth, parseSignatureSubpackets, and parseSignatureSubpacket
to prevent unbounded recursion.
Fixes golang/go#79923