argon2: update RFC 9106 parameter recommendations#357
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: 7d9441c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/789020. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/789020. |
|
Message from Gopher Robot: Patch Set 2: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/789020. |
|
Message from Harjoth Khara: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/789020. |
|
It seems like I cannot comment on Gerrit, so I'll reply here. The proposed changes are clear and they address the mismatch with the RFC. |
Update the IDKey example to use RFC 9106's second recommended Argon2id option and clarify the relationship between the first and second recommended options. Fixes golang/go#79823
7d9441c to
a764ae6
Compare
|
This PR (HEAD: a764ae6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/789020. Important tips:
|
Update the IDKey example to use RFC 9106's first recommended Argon2id
option and clarify the relationship between the first and second
recommended options.
Fixes golang/go#79823