cmd/compile: lower floating-point min/max to wasm instructions by timzifer · Pull Request #82074 · golang/go

timzifer · 2026-10-08T05:24:05Z

On wasm, floating-point min and max currently call runtime helpers even
though WebAssembly provides instructions with the required NaN and
signed-zero semantics.

Lower Min32F, Max32F, Min64F and Max64F to F32Min, F32Max, F64Min and
F64Max. This removes the runtime calls for both js/wasm and wasip1/wasm.

Add assembly checks for all four instructions and extend the existing
runtime min/max tests to cover float32 as well as float64, including
equal signed zeros.

Fixes #82073

On wasm, floating-point min and max currently call runtime helpers even though WebAssembly provides instructions with the required NaN and signed-zero semantics. Lower Min32F, Max32F, Min64F and Max64F to F32Min, F32Max, F64Min and F64Max. This removes the runtime calls for both js/wasm and wasip1/wasm. Add assembly checks for all four instructions and extend the existing runtime min/max tests to cover float32 as well as float64, including equal signed zeros. Tests pass with Node 24 for js/wasm and wasip1/wasm, and with Wasmtime for wasip1/wasm. The floats.go assembly checks pass with -all_codegen. Fixes golang#82073

google-cla · 2026-10-08T05:24:11Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2026-10-08T05:53:12Z

This PR (HEAD: db4958e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/846825.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-08T06:15:28Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.