Skip to content

net: don't panic on unsupported socket types in newFileFD - #82113

Open
gomaja wants to merge 1 commit into
golang:masterfrom
gomaja:net-filefd-unsupported-sotype
Open

gomaja wants to merge 1 commit into
golang:masterfrom
gomaja:net-filefd-unsupported-sotype

Conversation

@gomaja

@gomaja gomaja commented Oct 9, 2026

Copy link
Copy Markdown

newFileFD accepts any socket whose local address is an IPv4, IPv6 or
Unix address, but (*netFD).addrFunc only maps the socket types this
package supports and returns a nil Addr for any other. newFileFD then
dereferenced that nil Addr, so FileConn, FileListener and
FilePacketConn crashed the program when given, for example, an SCTP
SOCK_SEQPACKET socket.

Return EPROTONOSUPPORT instead, as newFileFD already does for an
address family it does not support.

Fixes #82051

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: bcaa3cd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/848187.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/848187.
After addressing review feedback, remember to publish your drafts!

newFileFD accepts any socket whose local address is an IPv4, IPv6 or
Unix address, but (*netFD).addrFunc only maps the socket types this
package supports and returns a nil Addr for any other. newFileFD then
dereferenced that nil Addr, so FileConn, FileListener and
FilePacketConn crashed the program when given, for example, an SCTP
SOCK_SEQPACKET socket.

Return EPROTONOSUPPORT instead, as newFileFD already does for an
address family it does not support.

Fixes golang#82051
@gomaja
gomaja force-pushed the net-filefd-unsupported-sotype branch from bcaa3cd to cc54def Compare October 10, 2026 06:01
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: cc54def) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/848187.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net: FileListener panics on an AF_INET SOCK_SEQPACKET (SCTP) socket

2 participants