Add serial transport#232
Open
trond-snekvik wants to merge 1 commit into
Open
Conversation
trond-snekvik
force-pushed
the
transport/serial
branch
4 times, most recently
from
2badb17 to
53bfd2d
Compare
Adds the serial transport layer, as outlined in golioth/architecture#85. This does not include a real transport adapter, but includes three test suites that test the serial device, serial broker and a test that covers both together, each using mock serial adapters and endpoints. Signed-off-by: Trond Snekvik <trond.snekvik@canonical.com>
trond-snekvik
force-pushed
the
transport/serial
branch
from
53bfd2d to
b945e26
Compare
szczys
reviewed
Jun 15, 2026
Comment on lines
-11
to
-15
| config POUCH_TRANSPORT_NONE | ||
| bool "NONE" | ||
| help | ||
| No transport is selected. Useful for unit testing. | ||
|
|
Contributor
There was a problem hiding this comment.
I think we need this for building unit tests without the dependencies of a given transport.
Comment on lines
-41
to
-46
| config POUCH_TRANSPORT_ACK_TIMEOUT_MS | ||
| int "Pouch Transport ACK timeout (ms)" | ||
| default 1000 | ||
| help | ||
| The timeout, in milliseconds, that a receiver will wait | ||
| for new packets before retransmitting an acknowledgement |
Comment on lines
+52
to
+55
| config POUCH_TRANSPORT_SAR | ||
| bool | ||
| help | ||
| Selected by transports that require Segmentation and Reassembly (SAR) |
Comment on lines
+170
to
+172
| pouch_atomic_clear_bit(&broker->flags, FLAG_SYNC); | ||
| pouch_atomic_clear_bit(&broker->flags, FLAG_DOWNLINK_DONE); | ||
| pouch_atomic_clear_bit(&broker->flags, FLAG_UPLINK_DONE); |
Contributor
There was a problem hiding this comment.
Do we need to clear the FLAG_INFO_READ flag here?
|
|
||
| void pouch_serial_broker_destroy(struct pouch_serial_broker *broker) | ||
| { | ||
| free(broker); |
Contributor
There was a problem hiding this comment.
Do we need any kind of teardown (ie: call end()) or check to ensure the broker isn't still in use?
| pouch_serial_ch_ready(&broker->serial.channels[ch]); | ||
| } | ||
|
|
||
| static void next(struct pouch_serial_broker *broker) |
| } | ||
|
|
||
| /* First prompt: open the transfer. */ | ||
| if (!pouch_atomic_test_and_set_bit(&ch->flags, CH_FLAG_OPEN)) |
Contributor
There was a problem hiding this comment.
This prevents opening a transfer when one is already open. Is it okay to silently return 0 when that happens?
| }; | ||
|
|
||
| *buf = pouch_serial_header_encode(&hdr); | ||
| pouch_atomic_clear_bit(&ch->flags, CH_FLAG_ERROR); |
Contributor
There was a problem hiding this comment.
It's tricky to understand why the error flag is cleared here.
|
|
||
| void pouch_serial_device_init(pouch_serial_device_ready_cb_t cb) | ||
| { | ||
| ready_cb = cb; |
Contributor
There was a problem hiding this comment.
Do we save this because it's a singleton? I'm wondering because the transport will also store it via the init command on the next line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the serial transport layer, as outlined in golioth/architecture#85. This does not include a real transport adapter, but includes three test suites that test the serial device, serial broker and a test that covers both together, each using mock serial adapters and endpoints.
There's some cleanup and some hacking in the kconfig menusystem going into this PR. The intent is to just kinda make serial build on both the gateway and the device without making our menuconfig worse. I'll make a separate PR with some more deliberate restructuring.