Repository navigation
refactor(dnsdiam): check discovered identities with DiameterIdentity.Valid - #138
Merged
Merged
Conversation
…Valid Discovered host and realm names now go through datatype.DiameterIdentity.Valid instead of dnsdiam's own copy of the rule. Service owner names such as _diameter._tcp keep their own check, which allows underscores (RFC 6733 §5.2 as updated by RFC 8553). Accepted names, ErrInvalid and the normalised names are unchanged. Require the go-diameter revision that adds Valid. Closes #132.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered host and realm names now go through
datatype.DiameterIdentity.Valid instead of dnsdiam's own copy of the rule.
Service owner names such as _diameter._tcp keep their own check, which
allows underscores (RFC 6733 §5.2 as updated by RFC 8553). Accepted
names, ErrInvalid and the normalised names are unchanged.
Require the go-diameter revision that adds Valid.
Closes #132.
Summary by cubic
Discovered host and realm names now go through
datatype.DiameterIdentity.Validinstead ofdnsdiam's own copy of the rule. Accepted names,ErrInvalid, and normalised names are unchanged; service owner names such as_diameter._tcpkeep their own check, which allows underscores (RFC 6733 §5.2 as updated by RFC 8553).Requires the go-diameter revision that adds
Valid. Closes #132.Written for commit a65625d. Summary will update on new commits.