Repository navigation
test: share one SCTP wire harness between the restart runners - #142
Merged
Merged
Conversation
The sm, peer and SCTP/TLS restart runners each carried their own copy of the same machinery, and only the sm runner built the tools image, so the peer and TLS runners failed on a machine where it had not run first. scripts/sctp-wire now holds the common part: building or verifying the tools image, now named sctp-wire-tools; compiling each fixture inside a container from a read-only copy of the source; the two-container network; the iptables rule that drops a stale ABORT on the receiver's INPUT; captures, artifact collection, cleanup and the tshark export. Each runner keeps its fixture, variants, timings and analyzer next to its package, builds the image itself when it is missing, and names its runs, containers, networks and scratch directories neutrally. The image build keeps its builder state in the run's scratch directory, while the caller's Docker context and credentials stay in effect. The peer analyzer now runs on the host's Python 3, like the other two. All 13 variants pass with their current packet assertions, including the peer and TLS runners started first on a machine without the image. Closes #131.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sm, peer and SCTP/TLS restart runners each carried their own copy of
the same machinery, and only the sm runner built the tools image, so the
peer and TLS runners failed on a machine where it had not run first.
scripts/sctp-wire now holds the common part: building or verifying the
tools image, now named sctp-wire-tools; compiling each fixture inside a
container from a read-only copy of the source; the two-container network;
the iptables rule that drops a stale ABORT on the receiver's INPUT;
captures, artifact collection, cleanup and the tshark export. Each runner
keeps its fixture, variants, timings and analyzer next to its package,
builds the image itself when it is missing, and names its runs,
containers, networks and scratch directories neutrally. The image build
keeps its builder state in the run's scratch directory, while the
caller's Docker context and credentials stay in effect. The peer analyzer
now runs on the host's Python 3, like the other two.
All 13 variants pass with their current packet assertions, including the
peer and TLS runners started first on a machine without the image.
Closes #131.
Summary by cubic
Shares the SCTP wire harness between the sm, peer, and SCTP/TLS restart runners so any of them can run first on a machine without the tools image, which previously only the sm runner built.
scripts/sctp-wire/harness.sh.sctp-wire-tools:go1.27.2and lets each runner build it when absent;SCTP_WIRE_IMAGEoverrides the tag.Written for commit 6f70aab. Summary will update on new commits.