Repository navigation
test: keep the scenario's status when SCTP wire cleanup fails or hangs - #146
Merged
Merged
Conversation
The shared SCTP wire harness ran its cleanup under set -e, so one failing Docker command ended the EXIT handler early: the run's scratch directory stayed behind and the runner exited with the cleanup's status instead of the scenario's. A hanging Docker command stopped cleanup for good, and a SIGINT or SIGTERM during cleanup replaced the status with 130. Cleanup now carries on past every failing command, bounds each Docker command it runs (60 s by default, then a forced kill), shields itself from further SIGINT and SIGTERM, always removes the scratch directory and returns the scenario's status. The Python harness tests cover failing, hanging and interrupted cleanup, each under its own deadline, and scripts/check.sh now runs them in its test step. The TLS restart runner and its fixture name their test binary, environment variables and readiness markers after the scenario. Closes #141.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared SCTP wire harness ran its cleanup under set -e, so one failing
Docker command ended the EXIT handler early: the run's scratch directory
stayed behind and the runner exited with the cleanup's status instead of
the scenario's. A hanging Docker command stopped cleanup for good, and a
SIGINT or SIGTERM during cleanup replaced the status with 130.
Cleanup now carries on past every failing command, bounds each Docker
command it runs (60 s by default, then a forced kill), shields itself from
further SIGINT and SIGTERM, always removes the scratch directory and returns
the scenario's status. The Python harness tests cover failing, hanging and
interrupted cleanup, each under its own deadline, and scripts/check.sh now
runs them in its test step.
The TLS restart runner and its fixture name their test binary, environment
variables and readiness markers after the scenario.
Closes #141.
Summary by cubic
Fixes the shared SCTP wire harness cleanup so a failing, hanging, or interrupted Docker command no longer replaces the scenario's exit status with the cleanup's, and the run's scratch directory is always removed.
scripts/check.shruns them in its test step.Closes #141.
Written for commit f745c01. Summary will update on new commits.